Repository navigation
feat(alerts): add ArgoraIPPoolImportInError alert - #38
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The alert follows established patterns, with only a non-blocking annotation wording issue.
1 open finding
What changed in this PR
Adds monitoring for Argora IPPoolImport resources stuck in an error state.
Changes:
- Adds a warning alert after 10 minutes in
Error. - Supports standard rule overrides and links the playbook.
| File | Description |
|---|---|
charts/controlplane-operations/alerts/controlplane-remote.yaml |
Defines the new Prometheus alert. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
defo89
force-pushed
the
feat/argora-ippoolimport-alert
branch
from
October 13, 2026 14:57
b5baa50 to
1a2f1c7
Compare
Add a new Prometheus alert for argora IPPoolImport CRs stuck in Error state. Follows the same pattern as ArgoraUpdateInError and ArgoraClusterImportInError alerts. Signed-off-by: Dmitri Fedotov <dmitri.fedotov@sap.com>
defo89
force-pushed
the
feat/argora-ippoolimport-alert
branch
from
October 13, 2026 15:00
1a2f1c7 to
85a2ba7
Compare
s10
approved these changes
Oct 13, 2026
rkschamer
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a new Prometheus alert
ArgoraIPPoolImportInErrorfor argoraIPPoolImportCRs stuck inErrorstate for more than 10 minutes.Motivation
The
IPPoolImportCR drives the import of IP pool prefixes from NetBox intoGlobalInClusterIPPoolobjects. When stuck in Error (e.g. invalid prefix role in NetBox, stale credentials, unreachable NetBox API), IP pools may not reflect the current state and new IP address allocations for compute/management transit networks can fail.The existing alerts cover
UpdateandClusterImportCRs but notIPPoolImport, leaving a monitoring gap.Changes
ArgoraIPPoolImportInErroralert tocontrolplane-remote.yamlArgoraUpdateInErrorandArgoraClusterImportInErrorkube_customresource_ip_pool_import_status{customresource_kind="IPPoolImport",customresource_group="argora.cloud.sap",state=~"Error"}for: 10m,severity: warningdisabled,service,support_groupoverrides via valuesNote
The corresponding playbook PR is being opened separately.
The kube-state-metrics CustomResourceStateMetrics configuration for
IPPoolImportmust include this CRD for the metric to exist — please verify this is configured.