Repository navigation
Conversation
defo89
force-pushed
the
feat/etcd-encryption-rotation-alerts
branch
from
October 9, 2026 14:57
d37e57c to
ed018ce
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The alert expressions miss never-successful CronJobs and can misclassify retrying Jobs as failed.
2 open findings
What changed in this PR
Adds monitoring for overdue and failed etcd encryption key rotations.
Changes:
- Adds overdue CronJob alert.
- Adds failed rotation Job alert.
| File | Description |
|---|---|
charts/controlplane-operations/alerts/controlplane-encryption.yaml |
Defines both encryption rotation alerts. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+10
to
+12
| ( | ||
| time() - kube_cronjob_status_last_successful_time{cronjob="etcd-kcp-backup-encryption-rotate"} | ||
| ) > 120 * 24 * 3600 |
| # state that needs investigation. | ||
| - alert: EtcdEncryptionRotationJobFailed | ||
| expr: > | ||
| kube_job_status_failed{job_name=~"etcd-kcp-backup-encryption-rotate-.*"} > 0 |
defo89
force-pushed
the
feat/etcd-encryption-rotation-alerts
branch
from
October 9, 2026 15:00
ed018ce to
dd7540e
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two PrometheusRule alerts for etcd encryption key rotation CronJob:
EtcdEncryptionRotationOverdue (warning)
EtcdEncryptionRotationJobFailed (warning)
Both alerts follow the same pattern as existing
controlplane-backup.yamlalerts and use standard kube-state-metrics.