Skip to content

Migration of the cf-java-client dependency - #1907

Open
karrgov wants to merge 15 commits into
masterfrom
cf_java_client_poc
Open

Migration of the cf-java-client dependency#1907
karrgov wants to merge 15 commits into
masterfrom
cf_java_client_poc

Conversation

@karrgov

@karrgov karrgov commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Migration of the cf-java-client dependency

github-advanced-security[bot]
github-advanced-security Bot found potential problems Sep 10, 2026
View reviewed changes
Comment thread ...g/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerRestClientBuilder.java Fixed
Comment thread ...g/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerRestClientBuilder.java Fixed
Yavor16
Yavor16 requested changes Sep 18, 2026
View reviewed changes
Comment thread ...rc/main/java/org/cloudfoundry/multiapps/controller/client/facade/domain/HealthCheckType.java Outdated
Comment thread ...lient/src/main/java/org/cloudfoundry/multiapps/controller/client/facade/domain/Metadata.java Outdated
Comment thread ...lient/src/main/java/org/cloudfoundry/multiapps/controller/client/facade/domain/Metadata.java Outdated
Comment thread ...lient/src/main/java/org/cloudfoundry/multiapps/controller/client/facade/domain/Metadata.java Outdated
Comment thread ...n/java/org/cloudfoundry/multiapps/controller/client/facade/rest/resources/V3Application.java Outdated
Comment thread ...g/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerRestClientFactory.java Outdated
Comment thread ...g/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerRestClientFactory.java Outdated
Comment thread ...g/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerRestClientFactory.java Outdated
Comment thread ...g/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerRestClientFactory.java Outdated
Comment thread ...g/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerRestClientFactory.java
Yavor16
Yavor16 requested changes Sep 18, 2026
View reviewed changes
Comment thread ...n/java/org/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerV3Client.java Outdated
Comment thread ...n/java/org/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerV3Client.java Outdated
Comment thread ...n/java/org/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerV3Client.java Outdated
Comment thread ...n/java/org/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerV3Client.java
Comment thread ...n/java/org/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerV3Client.java Outdated
Comment thread ...a/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceInstancesV3Operations.java Outdated
Comment thread ...a/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceInstancesV3Operations.java Outdated
Comment thread ...n/java/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceKeysV3Operations.java Outdated
Comment thread ...n/java/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceKeysV3Operations.java Outdated
Comment thread ...ler-client/src/main/java/org/cloudfoundry/multiapps/controller/client/facade/AllowNulls.java
Yavor16
Yavor16 requested changes Sep 29, 2026
View reviewed changes
Comment thread .../src/main/java/org/cloudfoundry/multiapps/controller/client/facade/domain/CloudAsyncJob.java Outdated
Comment thread ...n/java/org/cloudfoundry/multiapps/controller/client/facade/rest/resources/V3RouteMapper.java Outdated
Comment thread ...g/cloudfoundry/multiapps/controller/client/facade/rest/resources/V3ServiceBindingMapper.java
Comment thread ...ain/java/org/cloudfoundry/multiapps/controller/client/facade/domain/ServiceInstanceType.java Outdated
Comment thread ...va/org/cloudfoundry/multiapps/controller/client/facade/rest/resources/V3ServiceOffering.java Outdated
Comment thread ...ain/java/org/cloudfoundry/multiapps/controller/client/facade/rest/ProcessesV3Operations.java Outdated
Comment thread ...c/main/java/org/cloudfoundry/multiapps/controller/client/facade/rest/RoutesV3Operations.java Outdated
Comment thread ...va/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceBindingsV3Operations.java Outdated
Comment thread ...va/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceBindingsV3Operations.java Outdated
Comment thread ...va/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceBindingsV3Operations.java Outdated
Yavor16
Yavor16 requested changes Sep 29, 2026
View reviewed changes
Comment thread ...ava/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceBrokersV3Operations.java Outdated
Comment thread ...ava/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceBrokersV3Operations.java Outdated
Comment thread ...a/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceInstancesV3Operations.java Outdated
Comment thread ...a/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceInstancesV3Operations.java Outdated
Comment thread ...a/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceInstancesV3Operations.java Outdated
Comment thread multiapps-controller-client/src/main/java/module-info.java Outdated
Comment thread .../cloudfoundry/multiapps/controller/client/facade/rest/resources/V3ApplicationMapperTest.java Outdated
Comment thread ...loudfoundry/multiapps/controller/client/facade/rest/CloudControllerRestClientV3ImplTest.java Outdated
Comment thread ...loudfoundry/multiapps/controller/client/facade/rest/CloudControllerRestClientV3ImplTest.java Outdated
Comment thread ...va/org/cloudfoundry/multiapps/controller/client/facade/rest/CloudControllerV3ClientTest.java Outdated
theghost5800
theghost5800 reviewed Oct 5, 2026
View reviewed changes

@theghost5800 theghost5800 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of comments are repeatable or not but overall do the checks through all the code again if possible

Comment thread ...c/main/java/org/cloudfoundry/multiapps/controller/client/facade/adapters/LogCacheClient.java Outdated
Comment thread ...c/main/java/org/cloudfoundry/multiapps/controller/client/facade/adapters/LogCacheClient.java
Comment thread ...lient/src/main/java/org/cloudfoundry/multiapps/controller/client/facade/domain/Metadata.java Outdated
Comment thread ...lient/src/main/java/org/cloudfoundry/multiapps/controller/client/facade/domain/UserRole.java Outdated
Comment thread ...org/cloudfoundry/multiapps/controller/client/facade/rest/resources/LogCacheReadResponse.java Outdated
Comment thread ...va/org/cloudfoundry/multiapps/controller/client/facade/rest/ServiceKeysV3OperationsTest.java
Comment thread ...rg/cloudfoundry/multiapps/controller/client/facade/CloudControllerClientIntegrationTest.java
Comment thread multiapps-controller-client/pom.xml
Comment thread multiapps-controller-client/pom.xml
Comment thread pom.xml Outdated
theghost5800
theghost5800 reviewed Oct 5, 2026
View reviewed changes

@theghost5800 theghost5800 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of comments are repeatable or not but overall do the checks through all the code again if possible

karrgov added 12 commits October 13, 2026 08:30
@karrgov
CF Java Client PoC migration
586fa0f 
LMCROSSITXSADEPLOY-3563
@karrgov
Removing more leftovers, changing logging and removing cf-java-client…
909aab3 
… from poms

LMCROSSITXSADEPLOY-3054
@karrgov
Adding reactor-netty back not completed
1f6e566 
LMCROSSITXSADEPLOY-3563
@karrgov
Adding more fixes for the migration
24631cd 
LMCROSSITXSADEPLOY-3563
@karrgov
Fix test
0104970 
LMCROSSITXSADEPLOY-3563
@karrgov
Bettering everything as a whole - simplifications and logic changes
267c3bc 
LMCROSSITXSADEPLOY-3563
@karrgov
Adding unit tests for coverage and fixing Sonar
af165c3 
LMCROSSITXSADEPLOY-3563
@karrgov
Adding more unit tests and fixing existing ones
696856c 
LMCROSSITXSADEPLOY-3563
@karrgov
Fixing sonar issues and additional unit tests for coverage
cd813ba 
LMCROSSITXSADEPLOY-3563
@karrgov
Fixing comments
d32990e 
LMCROSSITXSADEPLOY-3563
@karrgov
Fixing comments from Yavor
7da4e02 
LMCROSSITXSADEPLOY-3563
@karrgov
Fixing final comments
e7fa4e6 
LMCROSSITXSADEPLOY-3563
@karrgov
karrgov force-pushed the cf_java_client_poc branch from 19c69f8 to e7fa4e6 Compare October 13, 2026 05:37
@sonarqubecloud

sonarqubecloud Bot commented Oct 13, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
10 Accepted issues

Measures
0 Security Hotspots
80.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theghost5800 theghost5800 theghost5800 left review comments
@vkalapov vkalapov vkalapov left review comments
@Yavor16 Yavor16 Yavor16 requested changes
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@karrgov @theghost5800 @Yavor16 @github-advanced-security @vkalapov