Repository navigation
fix(bundler): use net.JoinHostPort for IPv6 address formatting in BundleFromRemote - #1454
Open
AruneshDwivedi wants to merge 1 commit into
Open
AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
…dleFromRemote When building the dial address by concatenating ip/serverName with ':443', IPv6 literals produce invalid addresses like '2001:db8::1:443' instead of '[2001:db8::1]:443'. Use net.JoinHostPort which correctly adds brackets for IPv6 literals while leaving hostnames and IPv4 addresses unchanged. Fixes cloudflare#1448 Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building the dial address by concatenating ip/serverName with ':443', IPv6 literals produce invalid addresses like '2001:db8::1:443' instead of '[2001:db8::1]:443'. Use net.JoinHostPort which correctly adds brackets for IPv6 literals while leaving hostnames and IPv4 addresses unchanged.
Fixes #1448