Repository navigation
chore: Adds typing annotations to Coriolis - #542
Draft
claudiubelu wants to merge 1 commit into
Draft
claudiubelu wants to merge 1 commit into
claudiubelu wants to merge 1 commit into
Conversation
Adds argument and return type annotations to Coriolis, inferred from runtime types, by using RightTyper and running the integration tests. Methodology: - collection: run the integration tests under RightTyper. - emission: `righttyper process --python 3.10 --type-depth-limit=1` - normalisation: `self`, `cls`, `*args`, `**kwargs` left without annotations. Container types are kept shallow. Removed `-> None` from `__init__`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds argument and return type annotations to Coriolis, inferred from runtime types, by using RightTyper and running the integration tests.
Methodology:
righttyper process --python 3.10 --type-depth-limit=1self,cls,*args,**kwargsleft without annotations. Container types are kept shallow. Removed-> Nonefrom__init__.