Repository navigation
Fix endpoint Validate and Save persisting invalid values - #943
Open
mihaelabalutoiu wants to merge 4 commits into
Open
mihaelabalutoiu wants to merge 4 commits into
mihaelabalutoiu wants to merge 4 commits into
Conversation
mihaelabalutoiu
marked this pull request as draft
September 28, 2026 12:56
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
fix-endpoint-validate-and-save
branch
from
October 1, 2026 09:15
5adaffa to
2a117b1
Compare
mihaelabalutoiu
marked this pull request as ready for review
October 1, 2026 09:21
mihaelabalutoiu
marked this pull request as draft
October 12, 2026 09:49
Add `EndpointSource.validateConnectionInfo`, which validates the endpoint's platform and connection info through the `validate-connection-info` action, so it can be checked before it is saved. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Add `validateAndSave`, which validates the proposed values and only creates or updates the endpoint if they are valid, so a failed validation leaves nothing saved. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Validate the endpoint before saving it and keep the user's values when the validation fails. Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
fix-endpoint-validate-and-save
branch
from
October 12, 2026 11:11
2a117b1 to
9391763
Compare
mihaelabalutoiu
marked this pull request as ready for review
October 13, 2026 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
Validate and Savebutton saved the endpoint without waiting for validation, so invalid values were kept, and a later attempt could show the error of the previous values.This PR implements the following:
EndpointSource.validateConnectionInfo, which sends the form'splatform,connection_infoandmapped_regionsto the newvalidate-connection-infoaction on/endpoints/actions.createorupdatethe endpoint only if validation passes. When validation fails, nothing is saved and the stored endpoint is unchanged.