Repository navigation
Conversation
- story-play-verdict.mjs passes a play only when its completion was observed and no exception or error event fired; storyFinished's status reported success for a play that threw. The evidence gate needs playVerdicts, all PASS, on the storybook-plays run. - A changed UI component two or more hosts import requires every test and story covering it or a host, in both flag states when the change reads a flag, and blocks until the change log records the host the behavior is keyed on. - vibe 1.0.76 and its changelog. Testing: node --test (651 of 651) and pytest (2554) over the plugins on a second machine. Risks: a shared component change now needs every host's suites run before a pull request opens.
Collaborator
Author
|
Folded into #334 as part of the combined vibe 1.0.74 lessons release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
vibe 1.0.76 covers the two lessons-ledger entries added after #332 was scoped. This branch is stacked on #332 (
fix/vibe-lessons-20261021c), which is stacked on #331, and it is retargeted as those merge. Each lesson got a check inside the plugin first; prose only points at the check. No test here sends a signal, and every run happened on a second machine in a throwaway copy.Rung table
storyFinishedreports success when a play throwsstory-play-verdict.mjsjudges each play from recorded channel events: PASS only when a completion was observed and no exception or error event fired;storyFinished's status is never read. The PR evidence gate needsplayVerdicts, all PASS, on thestorybook-playsrun. The test runs a deliberately throwing play through a fake channel that reportsstoryFinished: success, and the verdict is FAILshared-consumers.mjs: a changed UI component that two or more non-test files import makes every test and story file covering it or a host a required run. When the change reads a flag, each run is needed with the flag on and off (flagStates;testRunsentries carryflag), andshared-flag-branchblocks until the change log records the host the behavior is keyed onCloseout per class
playVerdictson itsstorybook-playsrun, and its assertion is unchanged. A new assertion covers the missing case.importersOf), and the existingimporterCountsis derived from it, so there is no second grep.Ledger entries
Taken: both entries. Skipped: none.
Commands run
All on the second machine, in a throwaway copy:
node --testover everyplugins/**/*.test.{mjs,cjs,js},uv run pytest plugins/,uv run ruff check .anduv run pyright. Node 651 of 651, pytest 2554 passed, ruff and pyright clean.tools/vibe-workersis unchanged.