Repository navigation
ISS-12135: fix(vibe): keep local paths out of tickets and pull requests - #322
Merged
Merged
Conversation
- Hard rule: tickets, PR bodies, comments and replies never name a path on the operator's machine; screenshots are embedded, text is quoted inline, plans are linked or attached - pointerProblems in publishable-text.mjs, enforced by live-ticket-check and the pull request body gate - Fleet orchestrator: harness switch takeover, affected lanes before enqueue, release bump at enqueue, preview deploy ref, stale workers, scaffold on main, withdrawn instructions - Seeded or blank mode change through touch --mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
One release (vibe 1.0.67) for the vibe lessons ledger entries added on 2026-10-20 after #317 merged, headed by the operator's hard rule on local paths. Successor to #317; later lessons batch into this PR until it merges.
Lessons carried
Hard rule: no local paths in anything written for people (operator, 2026-10-20). Tickets, PR bodies, PR comments and review replies never reference a path on the operator's machine (home, temp, scratchpad, worktree or
.control/paths) or say something is on someone's laptop. Screenshots are uploaded and embedded (create-document-versioninlineImages), text evidence is quoted inline, briefly. Extension: a plan the ticket references is attached, never pointed at by path; an implementation plan is the PLN linked withcreate-artifact-link(PRODUCES), and a QA plan or other working file is uploaded withupload-attachmentand named by its attachment name.fleet-orchestrator/SKILL.md: new "Artifacts people read" section.fleet-orchestrator/references/templates.md: the worker preamble and the Codex resume prompt carry the rule, so every writer gets it.vibe/references/ticket-template.md: the live ticket rules (owner for ticket and PLN text); Visual evidence and Running app checks now carry embedded captures instead of.control/artifact paths, with the ticket worker and handoff SKILL.md updated to match.agents/vibe-environment-worker.md: the PR body and review replies follow the same rule.publishable-text.mjs pointerProblemsrefuses a line naming a local absolute or home path, a.control/capture or the local plans folder, never echoing the value.live-ticket-check.mjsreports each as aBodyproblem;pr-facts.mjsadds each toblocking.prBody. The new tests fail on a home-directory screenshot path, a tilde path, a.control/capture and a local plan path.Codex to Claude takeover (#8958 preview rebuild refused). The takeover preamble said vibe could not move a Codex session, so the Claude writer ran beside a ledger that still named the dead Codex writer and
dispatch-inputsrefused every environment request. vibe 1.0.66 already has theharnessSwitchmigration; the orchestrator skill and takeover preamble now use it before any other step. A seeded or blank mode change for a rebuild istouch --modeplus a new environment request (environment.md).Orchestrator rules (
fleet-orchestratorSKILL.md and judgment.md).green); check ancestry first.Not plugin changes (left out): the remote machine running vibe 1.0.54 (an upgrade, not a rule), and the #8953 drag-to-status note already encoded in #317.
Cost
agents/*.mdandskills/**/*.md): +46 / -20 lines, net +642 words, mostly the hard rule in its four owners.Commands run (final head)
uv run pytest plugins/vibe: 361 passednode --testover all 48 vibe*.test.mjsfiles: 438 passeduv run ruff checkanduv run pyrighton the changed Python test: cleanVersion
vibe 1.0.66 to 1.0.67 (both plugin manifests and the README), one CHANGELOG entry.