Repository navigation
Conversation
- Add child-evidence.mjs: a claimed child moves to In Review only when the adversarial reviewer's map evidences every criterion and work item on the final diff, a tracked file, a merged commit or a final-commit report - Require real activity for "active elsewhere" and a human ruling outside the session's own ticket and plan for any supersession - Quote PRD flag, rollout and boundary clauses as criteria, never narrow PRD targets, and never treat session-written text as provenance - Add node tests, a contract test module and two shared eval cases
- Fold the child evidence gate into live-ticket-check.mjs behind --child-evidence, so it runs in the ticket worker's step 8 check with no new script or dispatch - The ticket worker builds the map; drop the adversarial reviewer pass - Remove guardrails check 16 and the duplicated child, supersession and external dependency prose the gate replaces; compress the provenance rules
- Drop the provenance eval and the separate contract module; pin the gate and provenance rules in the existing lesson contract test - Compress the gate tests and remove the requirements sentence the gate now enforces
- A writer's own test that expects behavior no ticket, PRD or request names is a wrong test, not a reason to build it - Guardrails rule provenance covers every new user-reachable capability - Remove two quality-loop sentences that repeat guardrails test rules
…d-evidence # Conflicts: # CHANGELOG.md # plugins/vibe/.claude-plugin/plugin.json # plugins/vibe/.codex-plugin/plugin.json # plugins/vibe/README.md # plugins/vibe/agents/vibe-guardrails-reviewer.md # plugins/vibe/skills/handoff/scripts/live-ticket-check.mjs
Collaborator
Author
|
Folded into #317. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Works the open "claimed children, acceptance evidence and rule provenance" lessons from the vibe lessons ledger into the plugin. The claimed-children lesson repeated across six PRs (symphony-alpha #8947, #8953, #8958, #8959, #8960, #8963) and PRD-729, where unbuilt children reached IN_REVIEW on the writer's own audit. The 1.0.58 rule ("require delivery evidence") is prose and does not say what counts as evidence or who produces it. This change turns it into a gate the ticket worker cannot skip, inside a step vibe already has:
live-ticket-check.mjs, which the ticket worker already runs in handoff step 8, gains--child-evidence <map>. A child moves to IN_REVIEW only when every acceptance criterion and work item ismetwith evidence the script verifies: an added line in the diff, a tracked file the branch changed, a merged PR whose merge commit is in history, or a report produced on the final commit. It refuses a writer-authored map, pending or running evidence, a gitignored ledger, a named evidence path nothing covers, "active elsewhere" without an open PR, a branch commit in the last 7 days or another owner's IN_PROGRESS, and a supersession that cites the session's own ticket, plan or table.children.inReview. No new script, reviewer pass or dispatch.Cost
agents/*.mdandskills/**/*.md, excluding evals): 15,647 lines / 149,444 words on the base, 15,649 / 149,411 here: 2 more lines, 33 fewer words. Guardrails check 16, the duplicated child, supersession, active-elsewhere and external-dependency prose, and two quality-loop sentences repeating guardrails test rules are deleted.live-ticket-check.mjsand about 95 its node tests; there is no new script, reviewer pass, dispatch or step.git diff -U0andls-files(under a second) inside the existing ticket check, and the ticket worker builds the map while it already rereads each claimed child.Ledger lines
live-ticket-check.mjs --child-evidence(merged-prneeds a merge commit in history); ticket worker handoff modeinReviewslugs movediffevidence must be an added line of a changed filenamedEvidencePathsmust each carry evidencereportevidence must be produced on the final commitvibe-change-worker; the ticket worker builds ittrackedevidence must be tracked and changed by the branchrole=alertremoved against DONE ISS-9490 citing own precedentAffected files
plugins/vibe/skills/handoff/scripts/live-ticket-check-children.test.mjs, evalpm-claimed-child-moves-only-on-gateskills/handoff/scripts/live-ticket-check.mjs,agents/vibe-adversarial-reviewer.md,vibe-guardrails-reviewer.md,vibe-requirements-worker.md,vibe-ticket-worker.md,skills/handoff/SKILL.md,skills/vibe/SKILL.md,skills/vibe/references/quality-loop.md,tools/python/test_vibe_1057_lessons_contract.py(pins moved from deleted prose to the gate, two new tests),evals/codex/test_run.py(case count 71),README.md, both manifests,CHANGELOG.mdCommands run
uv run ruff check .: cleanuv run pyright: 0 errorsuv run pytest plugins/vibe/tools/python plugins/vibe/evals/codex/test_run.py: 329 passednode --testlive-ticket-check and its children gate tests: 15 passedtools/plugin-manifests:npm test6 passedVersion
vibe 1.0.67 in both manifests, on top of main 1.0.65 after #312, #316 and #318 merged; #313 takes 1.0.66, #317 1.0.68 and the orchestration PR 1.0.69. The version may still need re-resolving at merge.