Skip to content

fix(vibe): enforce workflow lesson checks - #311

Merged
shafty023 merged 1 commit into
mainfrom
feat/vibe-lessons-1057
Oct 19, 2026
Merged

shafty023 merged 1 commit into
mainfrom
feat/vibe-lessons-1057

Conversation

@shafty023

Copy link
Copy Markdown
Collaborator

Summary

  • Encode all twelve open vibe lessons in their owning agent or skill sections.
  • Make the handoff inventory fail closed for every disallowed path except verified shrink-only source-gate edits.
  • Treat source PRD children as scope units with claim, review, merge, and uncovered-work reconciliation.
  • Add Desktop build, real-host touch, Storybook train, telemetry, dependency, precedent, and version-flow gates.
  • Bump vibe to 1.0.58 and add twelve contracts plus four shared Claude Code and Codex eval cases.

Validation

  • uv run ruff check .
  • uv run pyright
  • uv run pytest plugins/vibe/tools/python plugins/vibe/evals/codex/test_run.py (327 passed)
  • Focused Node suites for handoff inventory and precedent checks (28 passed)
  • Plugin manifest parity (6 passed)
  • Full Python suite: 2433 passed and 3 skipped; two unrelated installer and contract issues were rerun after contention and passed
  • Full plugin Node suite: 422 passed; three unrelated process-timeout cases were rerun without contention and passed
  • TypeScript typechecks and tests passed for manifest parity, design inventory, review cost, and guided QA; generated bundles are current
  • The unchanged vibe-workers matrix experienced local parallel git-fixture timeouts; GitHub CI is authoritative for that lane

Risk

The stricter orchestration gates intentionally surface incomplete ticket scope, missing runtime evidence, and forbidden paths before pull request creation.

Enforce PRD child ownership, fail-closed handoff gates, runtime preconditions, and evidence-backed completion.

Add twelve lesson contracts and shared Claude Code and Codex eval cases.

Testing: Ruff, Pyright, 327 vibe Python tests, 28 focused Node tests, and manifest parity.

Risks: Prompt and handoff orchestration changes may surface more incomplete work before pull request creation.
@shafty023
shafty023 merged commit f65aec2 into main Oct 19, 2026
10 checks passed
@shafty023
shafty023 deleted the feat/vibe-lessons-1057 branch October 19, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant