Repository navigation
fix(theme): line-drawn chapter icons instead of the generated art - #448
Merged
Merged
Conversation
The sidebar's chapter icons were generated illustrations, and only four sections had one: clice's new Command Line, catter's Scripting and xclang's Build Systems and Reference had none. Every section now gets a line icon on the 24 px grid, stroked like the portal page's project icons: a signpost (guide), a toolbox (features), a terminal (cli), a page of code (scripting), a plug (integrations), a book (reference), a drafting compass (design), a wrench (dev). The generated icons go from public/icons, the project homes' feature icons with them (the homes redirect since #447).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asked by ykiko: drop the Codex-drawn icons and use something else. clice's Command Line section (new in the 1.0 docs) had no icon at all, nor catter's Scripting or xclang's Build Systems and Reference.
sidebar.ts: every sidebar section gets an inline line icon on the 24 px grid, stroked in the theme's blue like the portal page's project icons — signpost (guide), toolbox (features), terminal (cli), page of code (scripting), plug (integrations), book (reference), drafting compass (design), wrench (dev).public/icons/is deleted: the four chapter illustrations and the clice/catter feature icons, which only the project homes used (they redirect since fix(site): project homes go straight to their What-is pages #447).Checked: the 14 sections of clice, catter and xclang in light and dark; no built page names
/icons/;npm run buildpasses. The mascot art (logo, footer, 404, empty search, portal figure) stays.