Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/olive-rings-repeat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/nextjs': patch
---

Remove `https://images.clerkstage.dev` from the default `connect-src` Content Security Policy directive. It is a Clerk-internal storage host that no application connects to. Organization logos are served from `https://img.clerk.com`, which stays in the default.
Comment thread
Grundlefleck marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ describe('CSP Header Utils', () => {

expect(directives).toContainEqual("default-src 'self'");
expect(directives).toContainEqual(
"connect-src 'self' https://clerk-telemetry.com https://*.clerk-telemetry.com https://api.stripe.com https://maps.googleapis.com https://img.clerk.com https://images.clerkstage.dev https://*.protect.clerk.com:* clerk.example.com",
"connect-src 'self' https://clerk-telemetry.com https://*.clerk-telemetry.com https://api.stripe.com https://maps.googleapis.com https://img.clerk.com https://*.protect.clerk.com:* clerk.example.com",
);
expect(directives).toContainEqual("form-action 'self'");
expect(directives).toContainEqual(
Expand Down Expand Up @@ -116,7 +116,7 @@ describe('CSP Header Utils', () => {
const directives = headerValue.split('; ');
expect(directives).toContainEqual("default-src 'self'");
expect(directives).toContainEqual(
"connect-src 'self' https://clerk-telemetry.com https://*.clerk-telemetry.com https://api.stripe.com https://maps.googleapis.com https://img.clerk.com https://images.clerkstage.dev https://*.protect.clerk.com:* clerk.example.com",
"connect-src 'self' https://clerk-telemetry.com https://*.clerk-telemetry.com https://api.stripe.com https://maps.googleapis.com https://img.clerk.com https://*.protect.clerk.com:* clerk.example.com",
);
expect(directives).toContainEqual("form-action 'self'");
expect(directives).toContainEqual(
Expand Down Expand Up @@ -265,7 +265,7 @@ describe('CSP Header Utils', () => {

const directives = result.headers[0][1].split('; ');
expect(directives).toContainEqual(
`connect-src 'self' https://clerk-telemetry.com https://*.clerk-telemetry.com https://api.stripe.com https://maps.googleapis.com https://img.clerk.com https://images.clerkstage.dev https://*.protect.clerk.com:* clerk.example.com https://api.example.com`,
`connect-src 'self' https://clerk-telemetry.com https://*.clerk-telemetry.com https://api.stripe.com https://maps.googleapis.com https://img.clerk.com https://*.protect.clerk.com:* clerk.example.com https://api.example.com`,
);

const imgSrcDirective = directives.find(d => d.startsWith('img-src')) || '';
Expand All @@ -285,7 +285,7 @@ describe('CSP Header Utils', () => {
const directives = result.headers[0][1].split('; ');

expect(directives).toContainEqual(
"connect-src 'self' https://clerk-telemetry.com https://*.clerk-telemetry.com https://api.stripe.com https://maps.googleapis.com https://img.clerk.com https://images.clerkstage.dev https://*.protect.clerk.com:* clerk.example.com",
"connect-src 'self' https://clerk-telemetry.com https://*.clerk-telemetry.com https://api.stripe.com https://maps.googleapis.com https://img.clerk.com https://*.protect.clerk.com:* clerk.example.com",
);
expect(directives).toContainEqual("default-src 'self'");
expect(directives).toContainEqual("form-action 'self'");
Expand Down Expand Up @@ -331,7 +331,7 @@ describe('CSP Header Utils', () => {
const directives = result.headers[0][1].split('; ');

expect(directives).toContainEqual(
`connect-src 'self' https://clerk-telemetry.com https://*.clerk-telemetry.com https://api.stripe.com https://maps.googleapis.com https://img.clerk.com https://images.clerkstage.dev https://*.protect.clerk.com:* clerk.example.com`,
`connect-src 'self' https://clerk-telemetry.com https://*.clerk-telemetry.com https://api.stripe.com https://maps.googleapis.com https://img.clerk.com https://*.protect.clerk.com:* clerk.example.com`,
);
expect(directives).toContainEqual(`img-src 'self' https://img.clerk.com`);
expect(directives).toContainEqual(
Expand Down Expand Up @@ -397,7 +397,7 @@ describe('CSP Header Utils', () => {
const directives = result.headers[0][1].split('; ');

expect(directives).toContainEqual(
"connect-src 'self' https://clerk-telemetry.com https://*.clerk-telemetry.com https://api.stripe.com https://maps.googleapis.com https://img.clerk.com https://images.clerkstage.dev https://*.protect.clerk.com:* clerk.example.com",
"connect-src 'self' https://clerk-telemetry.com https://*.clerk-telemetry.com https://api.stripe.com https://maps.googleapis.com https://img.clerk.com https://*.protect.clerk.com:* clerk.example.com",
);
expect(directives).toContainEqual("default-src 'self'");
expect(directives).toContainEqual("form-action 'self'");
Expand Down
1 change: 0 additions & 1 deletion packages/nextjs/src/server/content-security-policy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ class ContentSecurityPolicyDirectiveManager {
'https://api.stripe.com',
'https://maps.googleapis.com',
'https://img.clerk.com',
'https://images.clerkstage.dev',
clerkProtectionConnectOrigin,
],
'default-src': ['self'],
Expand Down
Loading