fix(expo): fire onDismiss from the close button of an inline AuthView on iOS by mikepitre · Pull Request #10079 · clerk/javascript

mikepitre · 2026-10-05T20:54:36Z

Description

On iOS, the close button of a dismissible <AuthView /> did nothing when the view was rendered inline, and onDismiss never fired. isDismissible defaults to true and the component's own example renders it inline, so the documented usage shipped with a dead X. The same JSX already worked on Android.

The fix depends on clerk/clerk-ios#631, which shipped in clerk-ios 1.5.9. main already pins 1.5.9 (#10083), so this PR no longer touches the podspec. An earlier revision of this branch pinned the merge commit while the release was pending.

Why the button was dead: clerk-ios closes AuthView through SwiftUI's dismiss, and that has nothing to close for a view that is not presented. No UIKit dismissal reaches the bridge either, so there was nothing for @clerk/expo to observe. clerk/clerk-ios#631 adds a host dismiss action for this case, next to the host back action the bridge already uses. The bridge now passes one for a dismissible AuthView, and it emits the same dismissed event the bridge sends when the hosted view is detached. Inside a modal, clerk-ios still closes the view itself and the bridge sends the event once.

Android needed no change. clerk-android's AuthView takes onDismiss directly and the bridge already passes it.

I checked this with the verify skill from #10053, which is where the spec that caught it lives. Its dismiss test taps the X and waits for the fixture to go back to its home screen, and it passes on iOS and Android with this change. The iOS run was repeated against the 1.5.9 pin. That spec still carries a known-bug tag on #10053, and removing the tag is a follow-up there. This PR does not depend on it. The complete spec, which signs in through the form, was not run.

Before, on iOS. The spec taps the X at the end and the view stays:

before-ios.mp4

After, on iOS:

after-ios.mp4

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

🤖 Generated with Claude Code

vercel · 2026-10-05T20:54:43Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
clerk-js-sandbox	Ready	Preview	Oct 6, 2026 4:34pm UTC
swingset	Ready	Preview	Oct 6, 2026 4:34pm UTC

coderabbitai · 2026-10-05T20:54:46Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Team
Run ID: 5fa798c3-da9f-4e03-a32d-d662cb6a9eb6

📥 Commits

Reviewing files that changed from the base of the PR and between 3413ff0 and 96d8308.

📒 Files selected for processing (2)

.changeset/expo-inline-auth-view-dismiss.md
packages/expo/ios/ClerkNativeBridge.swift

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

clerk/clerk_go (manual)
clerk/dashboard (manual)
clerk/accounts (manual)
clerk/backoffice (manual)
clerk/clerk (manual)
clerk/clerk-docs (manual)
clerk/cloudflare-workers (manual)
clerk/clerk-ios (auto-detected)
clerk/clerk-android (auto-detected)
clerk/cli (auto-detected)

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Walkthrough

On iOS, makeAuthViewController now creates a dismiss callback when dismissible is true and passes it to both the hosting controller and the inline auth wrapper. The wrapper exposes the callback to the auth view through clerkHostDismissAction. A patch changeset describes the inline <AuthView /> dismissal fix.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to 96d83

The change is intended to let iOS inline auth dismissals reach the host. Available evidence identifies no specific remaining merge blocker.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the iOS inline AuthView close-button fix and the onDismiss behavior.
Description check	✅ Passed	The description explains the inline AuthView dismissal bug, the iOS bridge fix, and the reported verification results.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

Fix all pre-merge checks with AI

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

changeset-bot · 2026-10-05T20:54:47Z

🦋 Changeset detected

Latest commit: 96d8308

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@clerk/expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

… on iOS A dismissible AuthView that is rendered inline is not presented, so SwiftUI's dismiss had nothing to close and the bridge never heard about the tap. Pass clerk-ios a host dismiss action that emits the dismissed event. The podspec pins the clerk-ios commit that adds the action until a release contains it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

pkg-pr-new · 2026-10-05T21:06:56Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10079

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10079

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10079

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10079

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10079

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10079

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10079

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10079

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10079

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10079

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10079

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10079

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10079

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10079

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10079

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10079

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10079

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10079

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10079

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10079

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10079

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10079

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10079

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10079

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10079

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10079

commit: 96d8308

…-dismiss

1.5.9 contains the host dismiss action, and main already pins it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

github-actions · 2026-10-06T17:41:37Z

API Changes Report

Generated by Break Check on 2026-10-06T17:41:34.721Z

Summary

Metric	Count
Packages analyzed	19
Packages with changes	0
🔴 Breaking changes	0
🟡 Non-breaking changes	0
🟢 Additions	0

No API Changes Detected

All packages have stable APIs with no detected changes.

Report generated by Break Check

_{Last ran on 96d8308.}

wobsoriano

looks good!

mikepitre requested a review from wobsoriano October 5, 2026 20:54

vercel Bot deployed to Preview – clerk-js-sandbox October 5, 2026 20:55 View deployment

vercel Bot deployed to Preview – swingset October 5, 2026 20:56 View deployment

mikepitre added the do not merge label Oct 5, 2026

mikepitre force-pushed the mike/expo-inline-auth-dismiss branch from d07fde1 to 108670d Compare October 5, 2026 21:04

mikepitre changed the base branch from mike/expo-verify-skill to main October 5, 2026 21:04

vercel Bot deployed to Preview – clerk-js-sandbox October 5, 2026 21:05 View deployment

vercel Bot deployed to Preview – swingset October 5, 2026 21:07 View deployment

github-actions Bot added the expo label Oct 5, 2026

mikepitre and others added 2 commits October 6, 2026 12:28

Merge remote-tracking branch 'origin/main' into mike/expo-inline-auth…

5f4386c

…-dismiss

fix(expo): use the clerk-ios 1.5.9 release in place of the commit pin

96d8308

1.5.9 contains the host dismiss action, and main already pins it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

vercel Bot deployed to Preview – clerk-js-sandbox October 6, 2026 16:32 View deployment

vercel Bot deployed to Preview – swingset October 6, 2026 16:34 View deployment

mikepitre marked this pull request as ready for review October 6, 2026 17:37

mikepitre removed the do not merge label Oct 6, 2026

mikepitre requested a review from seanperez29 October 6, 2026 17:39

wobsoriano approved these changes Oct 6, 2026

View reviewed changes

mikepitre merged commit 18297a5 into main Oct 6, 2026
104 checks passed

mikepitre deleted the mike/expo-inline-auth-dismiss branch October 6, 2026 18:03

clerk-cookie mentioned this pull request Oct 6, 2026

ci(repo): Version packages #10074

Open

Navigation Menu

Repository navigation

fix(expo): fire onDismiss from the close button of an inline AuthView on iOS - #10079

fix(expo): fire onDismiss from the close button of an inline AuthView on iOS#10079
mikepitre merged 3 commits into
mainfrom
mike/expo-inline-auth-dismiss

mikepitre commented Oct 5, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Oct 5, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 5, 2026 •

edited

Loading

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

changeset-bot Bot commented Oct 5, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 5, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

wobsoriano left a comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mikepitre commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

vercel Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

changeset-bot Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 6, 2026

API Changes Report

Summary

No API Changes Detected

Uh oh!

wobsoriano left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mikepitre commented Oct 5, 2026 •

edited

Loading

vercel Bot commented Oct 5, 2026 •

edited

Loading

coderabbitai Bot commented Oct 5, 2026 •

edited

Loading

changeset-bot Bot commented Oct 5, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 5, 2026 •

edited

Loading