Conversation
…eys panel Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 7e4c5d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a skeleton for the user profile API keys panel's first load, built on the skeleton wave from #10029.
Table.Root,Table.HeaderCell, andTable.Celltakeskeleton. A skeleton cell renders one placeholder line in place of its children. A skeletonTable.Rootis hidden from assistive technology and drops the viewport'stabIndex.UserProfileApiKeysPanelSkeleton(inuser-profile-api-keys-panel.skeleton.tsx) renders the title, toolbar, column headers, and three rows as bones. It matches the wired panel's columns: name, created, last used, and actions. The name cell holds two lines, like a loaded key. The actions cell draws nothing and keeps the menu trigger's column width.isLoadingspinner stays until wire-up, which will add the delay/min-duration gate and swap in the skeleton.Open question:
Table.Search skeletonAPI, so either choice is cheap to change.Note: every
skeletonStyles.linebone measures 1/32px shorter than the text it replaces (a 32px title measures 31.97px, a 63px row 62.97px). Chrome snaps0.6lhand both0.2lhmargins down to 1/64px each. This comes from the shared primitive in #10029, so Section skeletons have it too.Preview: UserProfileApiKeysPanel, the Loading story at the end of Examples. Reload replays a 2s fake load.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
🤖 Generated with Claude Code