Repository navigation
Conversation
PageBrowse replaced the state initialized by SystemManagedList, dropping `sequence: 0`. The first row click then computed `undefined + 1`, so `sequence` became NaN. ComponentList.componentDidUpdate compares `this.props.sequence !== prevProps.sequence`, which is always true for NaN, so it kept calling setState and re-rendering the list forever. Keep the inherited state when PageBrowse sets its own, and add a regression test. Fixes clearlydefined#1130 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
❌ Deploy Preview for blissful-goodall-fa23f6 failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1130
Problem
On the home page (Browse list), clicking any component row freezes the tab. No console error appears, and opening a definition by direct URL works fine.
Cause
PageBrowsereplacesthis.statein its constructor, which drops thesequence: 0set by its base classSystemManagedList. The first row click runsincrementSequence(), computingundefined + 1, sosequencebecomesNaN.ComponentList.componentDidUpdatecomparesthis.props.sequence !== prevProps.sequence. That is always true forNaN, so it callssetStateon every update and the whole list re-renders forever.Fix
Spread the inherited state (
...this.state) before the Browse-specific fields in thePageBrowseconstructor.Testing
NaNcomparison.src/components/__tests__/PageBrowse.test.js; it passes with the fix and fails without it. Only that test file was run locally, not the full suite.🤖 Generated with Claude Code