[cjkas]

Summary

1. Live bugs

NVS: one Preferences handle per function instead of one global. loop() and async_tcp shared a single handle:

 loop()                              async_tcp (/saveRadio)
   pref.begin("ShadeCodes")
                                       pref.begin("CC1101")   // fails: handle already open
                                       pref.clear()           // clears ShadeCodes
   pref.putUShort(remote, code)
-  → every rolling code erased, paired motors ignore the next frames
+  each function opens its own Preferences; NVS serializes access itself

No lock or wrapper is added (see docs/adr/0001-local-nvs-handles-no-wrapper.md).

Where	Bug	Fix
SomfyGroup::emitState	Read a missing linked shade's flags through a null pointer	Only read flags for a shade that exists
/repeatCommand (shade)	Shade fields written inside an array: invalid JSON	Return an object, as the group branch and the web UI expect
MQTT groups/+/sunFlag/set	1 turned the sun flag off, 0 on	Shades and groups share sunFlagCommand()
Received StepDown, tilt-only shade	Tilt step set as the lift target	Set the tilt target
Received StepUp	Guarded downTime == 0 but divided by upTime	Guard the travel time of the direction stepped
Set-My (favorite)	200 ms settle delay counted from queueing, so it ran out while the stop ahead was still on air	A delayed job waits after the job ahead goes off air
Radio event ring	A full ring dropped a job outcome: favorite never committed, held shade waited 30 s	Jobs are refused unless both outcomes fit
Tilt and set-My commands	A command the radio refused was counted as sent	They return false; the web command queue logs it
/unpairShade	Cleared paired on the web server task; if TX was suspended the Prog was dropped after the client was told paired:false	Only loop() clears it, and the unpair waits for TX to resume
Sun and wind, tilt-only shade	Three callers set three different targets (lift, lift and tilt, tilt)	sensorTargets(): a tilt-only shade moves its tilt, others their lift
Sun and wind timers	64-bit timestamps of a 32-bit millis() fired at once after the 49.7-day rollover	32-bit, wrap-safe

2. Somfy.cpp split into files by concern

Somfy.cpp was 4,766 lines with ~690 that never compiled (#ifdef USE_NVS, commented-out code). The dead code is gone, and the rest moved unchanged:

src/
├── SomfyShade.cpp        # what a shade does (renamed Somfy.cpp, history follows)
├── SomfyRemote.cpp       # sending commands, rolling codes
├── SomfyGroup.cpp
├── ShadeController.cpp   # the shade list, rooms
├── ShadeGpio.cpp         # relay outputs of dry-contact shades
├── SomfyMqtt.cpp         # publish, Home Assistant discovery
├── SomfyEvents.cpp       # socket events
├── SomfyJson.cpp         # all config parsing
├── Transceiver.h/.cpp    # CC1101, radio task, frequency scan
├── PulseDecoder.h/.cpp   # received edges → frame bits (IRAM)   ← native tests
├── ShadeSensors.h/.cpp   # sun and wind timers and targets       ← native tests
├── ShadeMotion.cpp       # + stepTargets() for remote and group steps ← native tests
└── ShadeTypes.h          # shade, tilt and group kinds

The three tested modules replace logic that existed in two or three drifting copies. The plan and what changed are in docs/SOMFY_SPLIT_PLAN.md.

3. Debug build: --param=large-unit-insns=1000

At -Og, GCC only caps inlining growth in units over 10,000 instructions. Splitting Somfy.cpp let the smaller files inline ArduinoJson into every caller, and the image grew past the 1.5 MB partition. The flag treats every file as large; it is set for [env:esp32devdbg] only.

Evidence

• Before: sun timer on a tilt-only shade with favorite tilt 30 → lift target set to the lift favorite; tilt unchanged.
  After: test_sensors → test_tilt_only_shade_only_moves_its_tilt:

  sensorTargets(extend,  tiltonly, myPos 60, myTiltPos 30) → tilt 30, lift untouched
  sensorTargets(retract, tiltonly, ...)                    → tilt 0,  lift untouched
  

• Before: the receive decoder had no tests.
  After: test_pulse feeds it the edges sendFrame() produces:

  56-bit first frame (2 syncs) and repeat (7)  → payload decoded, bit_length 56
  80-bit first frame (12 syncs) and repeat (6) → payload decoded, bit_length 80
  glitch < bitMin → skipped; broken pulse mid-frame → next frame still decoded
  

• pio test -e native: 165 → 222 test cases, all passing.

• Flash, esp32devdbg: 1,561,977 → 1,545,717 bytes of 1,572,864 (99.3% → 98.3%). RAM 98,732 → 98,100.

• Builds locally: esp32devdbg, esp32dev, esp32c3, esp32s3. esp32c6 is left to CI.

• The split keeps all 253 top-level definitions of Somfy.cpp; git blame -C -C follows moved lines to their original commits.

• Hardware (not yet done):

  • Remote presses received from a 56-bit and an 80-bit remote
  • Shade commands go on air; frequency scan starts and stops
  • Save radio settings while sending commands; every shade still responds
  • MQTT groups/<id>/sunFlag/set 1 → flag on, 0 → off
  • Remote and group step on a lift shade and a tilt-only shade move one step
  • Sun flag on/off moves only a tilt-only shade's tilt; wind blocks a remote Down for 30 s
  • Unpair a shade; set a favorite

Merge Danger

Door: two-way

No stored formats change: NVS namespaces and keys, the shades file and the API routes are as before.

Blast Radius: radio

• Receiving: the decoder moved into its own IRAM function. A mistake there means no remote or sensor frames are received.
• Debug build: the inlining flag changes compiled code across the whole esp32devdbg image.
• Settings: every NVS read and write opens its own handle; a missed conversion would show as settings or rolling codes not loading or saving.
• Tilt-only shades with a sun sensor now move their tilt, not their lift, on sun and wind.
• MQTT: automations that inverted a group's sunFlag value to work around the old bug will now do the opposite.
• /repeatCommand for a shade now returns an object instead of invalid JSON.
• Roaming: a 6 dB stronger AP is now enough to roam; the old check needed 7 dB despite saying 6.
• Group steps on a tilt-only shade at its end, and steps on a shade with no travel time, now behave like remote steps.

🤖 Generated with Claude Code