Repository navigation
feat(python): value rules for every producible type #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+6,576
−61
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f08c9e7
feat(python): value rules for every producible type (#1392)
yujiyokoo 6c619a8
fix(python): address the review of the value rules (#1392)
yujiyokoo ad33624
fix(python): derive fuzz.yml's path filter from the fuzz locks (#1392)
yujiyokoo ee7d870
test(python): read the fuzz crates' compiled files with the shared wa…
yujiyokoo 96ca56a
fix(python): leave the copied value corpus out of Biome (#1392)
yujiyokoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix in a follow-up: nothing keeps
languages/python/crates/core/fuzz/Cargo.lockin step withlanguages/python/Cargo.lock.Impact: The re-seed instructions in
AGENTS.mdname onlylanguages/python/Cargo.lock. The fuzz task does not pass--locked. So after a re-seed, the fuzz target still builds the old versions of shared crates, with no error. The fuzz job then tests versions that the SDK no longer ships.Evidence: The fuzz task is
fuzz:python-valuesin the rootmise.toml. That file is not in this diff. Open it to see that the task has no--locked.Fix: Add one sentence to
AGENTS.md. After the re-seed, copy the lock over the fuzz crate'sCargo.lockand runcargo metadata --offlinethere. A better fix is a script test that fails when a package in both locks has different versions, likecipherstash-client-parity.test.mjs.Found by 1 model: claude