Skip to content

ci: report Lint + build on bundled-library PRs, where the dispatched run's checks never appear - #164

Merged
chodeus merged 1 commit into
betafrom
ci/dispatched-check-status
Nov 4, 2026
Merged

chodeus merged 1 commit into
betafrom
ci/dispatched-check-status

Conversation

@chodeus

@chodeus chodeus commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Bundled-library PRs never got the required Lint + build check, so #159 needed an admin merge.

  • vendor-sync pushes with GITHUB_TOKEN; CI on that push waits for an approval nobody gives, then fails when the PR closes
  • The CI it dispatches passes, but a dispatched run's checks never appear on the PR
  • Now a run dispatched for a PR (base set) ends with a report job that posts the Lint + build result as a commit status on that commit
  • Tested on throwaway draft test: dispatched status (throwaway, will be closed) #163 (a [skip ci] commit, so no other check): BLOCKED before the dispatch, CLEAN after, with only that status present
  • A failure in such a run counts as a PR run and no longer posts to Discord

Summary by CodeRabbit

  • Improvements
    • Validation runs triggered with a base reference now publish a success or failure status for the dispatched commit, with a link to the workflow run.
    • These runs no longer trigger the separate failure notification, avoiding duplicate failure reporting.

…run's checks never appear

- A run dispatched for a PR (base set) posts the Lint + build result as a commit status on that commit
- Without it the required check never reached the PR: CI on vendor-sync's push waits for approval, and dispatched checks stay off the PR
- A failure in such a run is treated like a PR run and no longer posts to Discord
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Walkthrough

The CI workflow adds a report job for dispatches with a nonempty base input. It posts a Lint + build commit status based on validation results and skips the failure notification job for these dispatches. The vendor-sync comment now describes the reporting path.

Changes: Manual CI status reporting

Layer / File(s) Summary
Report dispatched validation status
.github/workflows/ci.yml, .github/workflows/vendor-sync.yml
For dispatches with a nonempty base, the report job posts a Lint + build success status when validation succeeds and a failure status otherwise. It includes a link to the workflow run. The failure notification job skips these dispatches. The vendor-sync comment describes the approval wait and status reporting.

Estimated code review effort: 2 (Simple) | ~8 minutes

Sequence Diagram(s)

sequenceDiagram
  participant GitHubActions
  participant ValidateJob
  participant ReportJob
  participant CommitStatusAPI
  GitHubActions->>ValidateJob: Run validation
  ValidateJob-->>GitHubActions: Return validation result
  GitHubActions->>ReportJob: Run after validation when base is nonempty
  ReportJob->>CommitStatusAPI: Post Lint + build status and workflow run URL
Loading

Possibly related PRs

Merge Risk: Minimal · up to 702d7

This change reports the dispatched validation result as a Lint + build status on bundled-library PRs and stops posting their failures to Discord. No concrete merge-blocking defect remains. A narrow edge case exists when CI is manually re-dispatched on a commit that already passed, but it is low impact.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the change: a CI report that posts a Lint + build commit status for dispatched runs, which is the main change in ci.yml. The raw summary confirms a new report job posts that status for…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: a CI report that posts a Lint + build commit status for dispatched runs, which is the main change in ci.yml. The raw summary confirms a new report job posts that status for dispatches with a nonempty base input, and the vendor-sync.yml comment update matches the title's context. The title is specific and concise. It is 94 characters, which is longer than ideal, but it stays readable and within a single sentence.

Finishing Touches
Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 2973e2d and 702d724.

Files selected for processing: 2
  • .github/workflows/ci.yml
  • .github/workflows/vendor-sync.yml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.

@chodeus

chodeus commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Action performed

Full review finished.

@chodeus
chodeus marked this pull request as ready for review November 4, 2026 04:29
@chodeus
chodeus merged commit 3d3d642 into beta Nov 4, 2026
7 checks passed
@chodeus
chodeus deleted the ci/dispatched-check-status branch November 4, 2026 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant