Skip to content

refactor(sets): share SET_TYPES across frontend and edge - #526

Merged
chiptus merged 5 commits into
mainfrom
fix/UPL-50/consolidate-set-types
Nov 2, 2026
Merged

refactor(sets): share SET_TYPES across frontend and edge#526
chiptus merged 5 commits into
mainfrom
fix/UPL-50/consolidate-set-types

Conversation

@chiptus

@chiptus chiptus commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner

UPL-50: collapses the two TS copies of SET_TYPES into supabase/functions/_shared/setTypes.ts (imported in src/api/sets/types.ts via a new @functions alias).

Verification

  • Run pnpm test; it passes.
  • Create a set in the admin form with each set type; saves as before.
  • Run a schedule import with a set type column; imports as before.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TL8Yq3Q42iWAE8GCu58TTq

claude added 2 commits October 16, 2026 05:07
@claude
refactor(sets): share SET_TYPES between frontend and edge functions
e04b7b6 
Pin the sets_set_type_check constraint to SET_TYPES with a unit test.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CMhMAja3g8dwyMnAjVCLN2
@claude
docs(sets): rewrap setTypes comment
4dc341c
Copilot AI balanced review requested due to automatic review settings October 16, 2026 05:09
@vercel

vercel Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
upline Ready Ready Preview Nov 2, 2026 7:56pm UTC

@github-actions

github-actions Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploy → staging — workflow run
Last updated: 2026-11-02 20:08:04 UTC

  • ⏭️ DB migrations skipped (no changes)
  • ✅ Edge functions succeeded
  • ⏭️ Type generation skipped (no changes)

Copilot AI reviewed Oct 16, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused refactor preserves validation behavior, adds drift detection, and has no unresolved findings.

0 open findings

What changed in this PR

Centralizes set-type definitions shared by the frontend and edge functions, with a test to detect database constraint drift.

Changes:

  • Reuses shared constants, types, and validation through frontend exports.
  • Adds a migration-based constraint consistency test.
  • Updates documentation to describe the shared definition.
File Description
supabase/​functions/​_shared/​setTypes.ts Documents the shared definition and drift test.
src/​lib/​setTypeConstraint.test.ts Checks constraint values against SET_TYPES.
src/​api/​sets/​types.ts Replaces duplicate definitions with shared exports.

🧠 Review effort: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@chiptus

chiptus commented Oct 16, 2026

Copy link
Copy Markdown
Owner Author

test / run failed before any test ran: supabase start couldn't pull its Docker images (toomanyrequests: Data limit exceeded). That is a registry rate limit, not caused by this PR, which only touches SET_TYPES and a unit test. Unit tests, typecheck/lint and edge function tests are green. I'm re-running the failed job once.

Generated by Claude Code

@github-actions

github-actions Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Playwright test results

passed  68 passed

Details

stats  68 tests across 22 suites
duration  1 minute, 32 seconds
commit  82f6c0f

chiptus
chiptus commented Oct 22, 2026
View reviewed changes
Comment thread src/lib/setTypeConstraint.test.ts Resolved
Comment thread supabase/functions/_shared/setTypes.ts Resolved
@chiptus

chiptus commented Oct 23, 2026

Copy link
Copy Markdown
Owner Author

Run Edge Function Tests failed on de4490a before any test ran: supabase start couldn't pull its Docker images (toomanyrequests: Data limit exceeded / ECR timeouts). Same registry rate limit as the earlier test / run failure, which passed on re-run. It isn't caused by this PR's change, which only touches SET_TYPES and a unit test. I'm re-running the failed job once.

Generated by Claude Code

@chiptus

chiptus commented Oct 23, 2026

Copy link
Copy Markdown
Owner Author

The re-run of Run Edge Function Tests on de4490a hit the same Docker toomanyrequests: Data limit exceeded error while starting local Supabase, again before any test ran. Nothing in this PR can fix that, so I'm not re-running a third time. The test / run jobs got their one re-run and are pending. Once the registry limit clears, re-running the failed jobs should turn this green.

Generated by Claude Code

@chiptus

chiptus commented Oct 25, 2026

Copy link
Copy Markdown
Owner Author

CI is red on test / run, report / report and Run Edge Function Tests, but not because of this PR. The supabase start step failed pulling docker images with toomanyrequests: Data limit exceeded, which is a registry rate limit. Unit tests, typecheck and lint pass. No code fix exists for this, so I re-ran the failed jobs once. The open review thread ("do we really need this test?") is waiting on your call.

Generated by Claude Code

@chiptus

chiptus commented Oct 26, 2026

Copy link
Copy Markdown
Owner Author

CI test / run failed before any test ran: supabase start couldn't pull images (toomanyrequests: Data limit exceeded from the registry). That's runner infrastructure, not this PR's diff. I re-ran the failed jobs once; if it fails again it's still the registry limit and needs a maintainer re-run later.

Generated by Claude Code

@chiptus

chiptus commented Oct 27, 2026

Copy link
Copy Markdown
Owner Author

test / run failed on this head for an infra reason, not the diff: Docker image pulls hit toomanyrequests: Data limit exceeded. Re-ran the failed jobs once. The open thread ("do we really need this test?") is waiting on your call; I've offered to drop the test.

Generated by Claude Code

@chiptus

chiptus commented Nov 2, 2026

Copy link
Copy Markdown
Owner Author

functions / Deploy edge functions (staging) failed on 82f6c0f with unexpected deploy status 404: Cannot retrieve service for project kkwytldrrxenrenjzfpk with currect status 'INACTIVE'. The staging Supabase project is paused/inactive, so any PR that deploys edge functions will fail here regardless of its diff. No code fix exists. Restoring the staging project in the Supabase dashboard and re-running the failed job should clear it.

Generated by Claude Code

@chiptus
chiptus merged commit d7c5137 into main Nov 2, 2026
23 of 24 checks passed
@chiptus
chiptus deleted the fix/UPL-50/consolidate-set-types branch November 2, 2026 20:09

This branch was successfully deployed

2 active deployments
staging — 82f6c0f8 Deployed Nov 2, 2026 by chiptus via functions / Deploy edge functions (staging) #151
Preview — 82f6c0f8 Deployed Nov 2, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chiptus @claude