Skip to content

ci: pin the shared release workflows to v4.1.0 - #2254

Merged
chhoumann merged 1 commit into
masterfrom
ci/plugin-workflows-v4.1.0
Oct 24, 2026
Merged

chhoumann merged 1 commit into
masterfrom
ci/plugin-workflows-v4.1.0

Conversation

@chhoumann

@chhoumann chhoumann commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

Summary

Since #2253 added pnpm-workspace.yaml, the shared release workflows pinned at ebcf84b (v4) run pnpm --dir .release-toolkit install inside QuickAdd's workspace. That install pulls QuickAdd's packages instead of the toolkit's and still exits 0, which breaks the next release. chhoumann/obsidian-plugin-workflows v4.1.0 (149e378) fixes it: the toolkit is its own workspace root, and it runs on pnpm 10.34.7.

Changes

  • release-prepare.yml, release-trigger.yml and release.yml pin 149e37801b35c120660a1fd5e78a5471fda55726 # v4.1.0. The v4.1.0 tag object dereferences to that SHA.
  • Inputs, secrets and permissions are unchanged. Per the v4.1.0 notes, the caller contract is the same as ebcf84b.

Testing / validation

After merge, a dry run of Prepare release (dry-run: true) on master confirms that the toolkit install uses pnpm 10.34.7 and installs the toolkit's own dependencies.

Checklist


Note

Low Risk
CI-only pin bump with the same caller contract; lowers risk of broken releases versus staying on v4.

Overview
Bumps the reusable chhoumann/obsidian-plugin-workflows pins from commit ebcf84b (v4) to 149e378 (v4.1.0) in release-prepare.yml, release-trigger.yml, and release.yml.

That upgrade fixes release prep after the repo’s pnpm-workspace.yaml caused v4’s toolkit install to resolve QuickAdd’s workspace packages instead of the release toolkit’s—silently succeeding but breaking later release steps. v4.1.0 treats the toolkit as its own workspace root (pnpm 10.34.7). Workflow inputs, secrets, and permissions are unchanged.

Reviewed by Cursor Bugbot for commit e553072. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Pin shared release workflows to v4.1.0

Updates the prepare job in release-prepare.yml to use the shared release-preparation workflow at commit 149e378, tagged v4.1.0. Job conditions, permissions, inputs, and secrets are unchanged.

Macroscope summarized e553072.

Summary by CodeRabbit

  • Chores
    • Updated the release automation to use version 4.1.0 of its reusable workflows. This affects preparation, validation, and publishing of releases; no changes to release inputs or permissions are included.
    • No direct changes to the product experience are noted.

A caller pnpm-workspace.yaml made the v4 (ebcf84b) toolkit install resolve to QuickAdd's workspace, so it installed QuickAdd's packages instead of the toolkit's and still exited 0. v4.1.0 makes the toolkit its own workspace root and moves it to pnpm 10.34.7. No inputs, secrets or permissions change.
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 570f2c7e-cd99-449f-86d3-b4267e70e7db
Commits

Reviewing files that changed from the base of the PR and between c45eaf2 and e553072.

Files selected for processing: 3
  • .github/workflows/release-prepare.yml
  • .github/workflows/release-trigger.yml
  • .github/workflows/release.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

Three GitHub Actions release workflows now reference reusable workflows pinned to the v4.1.0 commit. Their other inputs, permissions, and secrets remain unchanged.

Changes: Release workflow references

Layer / File(s) Summary
Update reusable workflow pins
.github/workflows/release-prepare.yml, .github/workflows/release-trigger.yml, .github/workflows/release.yml
All three workflows now use commit 149e37801b35c120660a1fd5e78a5471fda55726 instead of the v4 commit. Other workflow settings remain unchanged.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

  • chhoumann/quickadd#2253: This PR changed the workspace setup, and the supplied summary links that change to the release workflow behavior updated here.
Merge Risk: Minimal · up to e5530

The workflow pin updates preserve the reported caller configuration and introduce no actionable merge risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: pinning the shared release workflows to version v4.1.0.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the pins in place
Three workflows turn to v4.1.0
No inputs shift, no secrets roam
The release path keeps its form
Then off I hop, with carrots home

Comment @coderabbitai help to get the list of available commands.

@chhoumann
chhoumann merged commit 6802ac8 into master Oct 24, 2026
16 of 18 checks passed
@chhoumann
chhoumann deleted the ci/plugin-workflows-v4.1.0 branch October 24, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant