Repository navigation
fix(reporters): report CLI-side timeouts as timed out, not failed [RED-1276] [ship] - #1582
Merged
Merged
Conversation
When the CLI stops waiting for a check result, the check may still pass in Checkly, yet the GitHub markdown table showed it as a plain failure. The runner now flags timeouts on CHECK_FAILED, the test, trigger and pw-test commands pass the flag through as result.timedOut, and the github reporter renders those rows as "Timed out". Other run errors (backend errors, result processing failures) still show as failed. Refs #979 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A check the CLI stopped waiting for may still pass in Checkly, but the list, ci, dot and json reporters reported it as an ordinary failure. Add a TIMED_OUT check status for results flagged timedOut: titles use a ⏱ symbol, the summaries count "N timed out" separately from failures, the dot reporter prints a T mark, and the json reporter emits "result": "Timed out". Other run errors still report as failed, and exit codes and the max failures limit are unchanged. Refs #979 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sorccu
changed the title
sorccu
changed the title
sorccu
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear: RED-1276
Affected Components
When the CLI stops waiting for a check result (its per-check
--timeout), the check may still finish and pass in Checkly. Every reporter still showed such checks as plain failures, so the CLI output disagreed with the test session and looked like a real failure. That mismatch is what the linked issue reports for the GitHub reporter.This PR reports those checks as timed out:
CheckFailureargument ({ timedOut: true }) withCHECK_FAILED, set only when the CLI-side timeout fires.test,triggerandpw-testpass it through to reporters asresult.timedOut.CheckStatus.TIMED_OUT, whichresultToCheckStatusreturns for those results, drives the output:⏱️ Timed out(with the retry count, if any) instead of❌ Fail.⏱symbol, and the summaries countN timed outseparately fromN failed.Tmark, and the brief summary counts timed-out checks separately."result": "Timed out"instead of"Fail".The run's exit code is unchanged: a timed-out check still makes the run exit 1, because the CLI never received a result. Timed-out checks also still count toward
--max-failures.Notes for the Reviewer
resultfield gains a new value."Timed out"joins"Pass","Fail","Degraded"and"Not finished". A script that finds failures by matchingresult === "Fail"will no longer see timed-out checks. Such a script should rely on the exit code or also match"Timed out". The docs will need a matching line next to the existing"Not finished"description, as a follow-up.errormessage from the backend, or a final result the CLI failed to process) are left unflagged and still report as failed. The flag is set explicitly by the runner, not inferred by matching the error message text.🤖 Generated with Claude Code