Repository navigation
Conversation
Ticket: ENT-6451 Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor.ProcessAPIEvents
branch
from
October 29, 2026 12:23
163d425 to
da2cb18
Compare
victormlg
marked this pull request as ready for review
October 29, 2026 12:38
Contributor
Author
|
The error is unrelated. Nightlies are missing packages for ubuntu 22 |
larsewi
reviewed
Oct 30, 2026
| # @note Beginning with 3.20.0 the materialized_hosts_view_refresh CLI task no | ||
| # longer exists in Mission Portal, so this bundle does nothing. | ||
| { | ||
| @if before_version(3.20.0) |
Member
There was a problem hiding this comment.
No, it was 3.20 https://github.com/cfengine/mission-portal/commit/0d6c473ecdcf0b760ca5fcd29ac84e6cea3c642d
and then backported to 3.18.2 https://github.com/cfengine/mission-portal/commit/8de56679a8138eec935b2a21edbf76ee2d34bcf8
nickanderson
approved these changes
Oct 31, 2026
nickanderson
left a comment
nickanderson
left a comment
Member
There was a problem hiding this comment.
I am curious why you chose a macro for this.
| # @note Beginning with 3.20.0 the materialized_hosts_view_refresh CLI task no | ||
| # longer exists in Mission Portal, so this bundle does nothing. | ||
| { | ||
| @if before_version(3.20.0) |
Member
There was a problem hiding this comment.
Why a macro for this instead of adjusting a class expression?
you also have the functions related to these macros you could use to further constrain the context under which a promise runs.
e.g.
if => or( cf_version_before( "3.18.2" ),
cf_version_at( "3.19" ) );
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.