Repository navigation
chore(garm): bump workload to fix startup on upgraded postgresql databases - #429
Merged
Merged
Conversation
…bases Pin GARM to the merge of cloudbase/garm#922. PostgreSQL databases that went through GARM's migration 0003 have text forge_instance_id columns, so migration 0008 failed with "operator does not exist: text = uuid" and GARM did not start (cloudbase/garm#920). The new migration 0007a converts those columns before 0008 runs.
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The workload bump includes additional database migrations that warrant human review of production upgrade and rollback safety.
0 open findings
What changed in this PR
Updates the pinned GARM workload to restore startup on older PostgreSQL databases affected by incompatible forge instance column types.
Changes:
- Pins GARM to
ae281e37, which includes the upstream migration repair. - Documents the startup fix in the changelog.
| File | Description |
|---|---|
garm-rockcraft.yaml |
Updates the workload commit and explains the migration fix. |
docs/changelog.md |
Records restored startup for affected PostgreSQL databases. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cbartz
marked this pull request as ready for review
October 15, 2026 09:13
cbartz
requested review from
florentianayuwono,
javierdelapuente,
weiiwang01,
yanksyoon and
yhaliaw
as code owners
October 15, 2026 09:13
florentianayuwono
approved these changes
Oct 15, 2026
gregory-schiano
approved these changes
Oct 15, 2026
yanksyoon
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Bumps the pinned GARM workload commit to the merge of cloudbase/garm#922.
Why we need it
Upgrading GARM to the previous pin (
93377e7f) failed on our production PostgreSQL database. The startup migration 0008 errored withoperator does not exist: text = uuid, and GARM didn't start, so we rolled back. PostgreSQL databases that went through GARM's migration 0003 havetextinstead ofuuidforge_instance_idcolumns (cloudbase/garm#920). #922 adds a migration that converts them before 0008 runs.Checklist
CONTRIBUTING.mdhas been updated upon changes to the contribution/development process (e.g. changes to the way tests are run)docs/changelog.mdwith user-relevant changes(e.g., in
.github/workflows/integration_tests.yaml, ensure themoduleslist is correct)terraform fmtpasses andtflintreports no errorsAGENTS.md.copilot-collections.yamlor.github/instructions/: I re-checked whether theAGENTS.md"12-factor divergences" guidance still matches the upstream copilot-collections guidanceNot applicable or not ticked:
versionstays0.2; it isn't bumped per workload pin (see fix(garm): bump pinned commit to fix scale set pool ID tag length #351).CONTRIBUTING.md, Grafana, Terraform,AGENTS.mdand copilot-collections are untouched.Test plan
840558b5, and added rows with both live and orphaned forge instance references.93377e7ffailed on it with the production error.ae281e37(this pin) migrated it through 0011: columns converted touuid, foreign keys created, live references kept, orphans resolved.cmd/garmstatically at the new pin with the rock's build tags and the Go 1.26 snap.garm) on the rebuilt rock.Review focus
generate_client.shstay where they were. The only existing endpoint whose shape changed is the jobs list, which is now paginated. The charm doesn't use it; everything else in the swagger diff is new endpoints.AI-generated message.