Repository navigation
build: pin the node base image in every file that names one - #1009
Merged
Merged
Conversation
Dockerfile pinned node:24.22.1-alpine by digest, but Dockerfile.railwayapp, Dockerfile.test and the two compose files still said node:24-alpine, so the relay image, the CI image, the Railway image and both migration containers could each start from a different base - and a floating tag moves under a release, so the same commit built twice could run different node code. All five now carry the same tag and digest, and a unit test holds them together: it fails if any reference loses its digest, and it fails if two different references appear, which is how #1005 left these behind. Verified: the new spec passes; reverting Dockerfile.test to node:24-alpine fails it on both counts; the rest of test/unit/ci is 26 passing.
🦋 Changeset detectedLatest commit: ad8c5c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
 [Medium impact] The PR appears safe to merge; no blocking issues were identified.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Collaborator
Coverage Report for CI Build 41234711032Coverage decreased (-0.006%) to 77.35%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
chappie-daemon
added a commit
that referenced
this pull request
Oct 31, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## nostream@3.10.0 ### Minor Changes - [#922](#922) [`fcb33de`](fcb33de) Thanks [@Priyanshubhartistm](https://github.com/Priyanshubhartistm)! - feat(payments): add per-plan event rate limits and retention ### Patch Changes - [#1009](#1009) [`ad8c5c4`](ad8c5c4) Thanks [@chappie-daemon](https://github.com/chappie-daemon)! - build: pin the node base image in every file that names one `Dockerfile` pinned `node:24.22.1-alpine` by digest, but `Dockerfile.railwayapp`, `Dockerfile.test`, `docker-compose.yml` and `test/integration/docker-compose.yml` still said `node:24-alpine`. The relay image, the CI image, the Railway image and both migration containers could each start from a different base, and a floating tag moves under a release — so the same commit built twice could run different node code without a change saying so. All five now carry the same tag and digest, and a unit test holds them there: it fails if any reference loses its digest, and it fails if two different references appear. - [#1010](#1010) [`fa54cb0`](fa54cb0) Thanks [@chappie-daemon](https://github.com/chappie-daemon)! - fix(settings): state that rate-limit periods are milliseconds and reject a period that is not one Every shipped limit counts in milliseconds — `1000`, `60000`, `900000`, `3600000` — but nothing said so. `RateLimit.period` is a bare `number`, so an operator writing `period: 60` for a minute got a 60 ms window — and because `rate` is hits per window, that is a limit a thousand times **looser** than intended, honoured without complaint, and caught by nothing. The unit is now stated on `RateLimit` and on every `rateLimits` block in `resources/default-settings.yaml`, and `validateRateLimitPeriods` rejects what cannot be a count of milliseconds: a fraction, a string, a non-number, or anything below one millisecond. A whole number is not enough to tell 60 from 60000, which is why the unit is documented where it is set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Dockerfilepinnednode:24.22.1-alpineby digest in #1005, but four other files that name a node base image still saidnode:24-alpine:Dockerfile.railwayappDockerfile.testdocker-compose.ymlnostream-migratetest/integration/docker-compose.ymlmigrations-testAll five now carry the same tag and digest.
Why it matters
A floating tag means the relay image, the CI image, the Railway image and both ephemeral migration containers can each start from a different base, and a release can run different node code than the one before it without a commit saying so.
Guard
test/unit/ci/node-base-pin.spec.tscollects everyFROM node:…andimage: node:…in the repo and asserts two things: each carries a digest, and all of them are the same reference. That second check is what #1005 lacked — it pinnedDockerfileand left the rest behind, and nothing noticed.It also asserts the scan found the expected rows, so a glob that silently matches nothing cannot make the suite green.
Verification
Dockerfile.testtonode:24-alpine: fails on both counts (digest and single reference)test/unit/ci/**: 26 passing