Skip to content

Fix Bases view settings compatibility (#2382) - #2384

Merged
callumalpass merged 1 commit into
mainfrom
fix/2382-bases-view-settings
Oct 4, 2026
Merged

callumalpass merged 1 commit into
mainfrom
fix/2382-bases-view-settings

Conversation

@callumalpass

Copy link
Copy Markdown
Owner

Summary

Related to #2382, reported by @techwiththiru.

TaskNotes previously generated custom Bases view settings under options: or config:, while Kanban read only direct view keys. This left settings such as hideEmptyColumns and pinnedColumns unread.

  • Read direct settings first, then legacy config: and options: values, preserving explicit false, zero, and empty values.
  • Support legacy settings across TaskNotes views without rewriting existing .base files; retain Calendar's existing options: support.
  • Reflect legacy values in the native settings-panel defaults.
  • Generate flat settings in default Kanban, Calendar, and Agenda files and v3 saved-view exports.
  • Correct documentation examples and add unit and isolated native Obsidian regression coverage.

Validation

Passed locally:

  • Full Jest suite: 4,620 passed, 1,013 skipped, 4 todo.
  • Strict lint (including review-types, CSS, and architecture checks).
  • TypeScript typecheck.
  • Production build.
  • Bundle budget: 4,544,771 bytes, below 5,000,000 bytes.
  • Documentation source checks and git diff --check.

Native test limitation

The isolated Obsidian E2E run was blocked in beforeAll by a DevTools startup timeout. None of the eight native scenarios reached their assertions. Live-app verification remains incomplete; this PR does not claim those tests passed.

The issue is intentionally not automatically closed by this PR.

@callumalpass
callumalpass merged commit 69535cd into main Oct 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant