Repository navigation
Add native SDK planner data adapter foundation - #7
Conversation
|
BLOCK 9ccf195 — one-pass foundation review, including the SDK #804/source-write delta. The previous-head task fixes preserve submission identity and require confirmed, unprotected current readback. Three remaining correctness deltas:
Independent checks: frozen install, unchanged-head targeted repository/view/source tests 34 PASS / 3 files, actual Please address these narrow deltas with regression coverage on this same draft PR. No second whole-app/browser matrix or sign-in/setup/engine rewrite requested. Existing Connect remains default; shared session/factory and native runtime qualification are separate dependencies. No source ACK yet. |
|
Addressed the three correctness findings from comment6098727896 in b240e04, on this same draft PR:
Reproduced the five reviewer regressions RED on 9ccf195, then GREEN after the fixes. Narrow suite: 45 tests / 3 files PASS, including create-grant, protected-state and alternate-provider recovery coverage. Actual Please review only this correctness delta. Existing Connect remains default; SDK804 data-only pin unchanged. |
|
ACK b240e04 Requested correctness delta only confirmed: selected-subtree anchors/aliases refuse before capture; live task confirmation/recovery retains the original portable identity/provider/config witness; supplied grant/status and current native source state determine writability, with create/edit preflight before intent/helper. No SDK pin/auth/setup/engine changes. This resolves BLOCK6098727896. Prior independent source review/unchanged-head 34 tests/3 files and actual project types stand. Owner five reviewer regressions RED→GREEN plus narrow 45/3/types/lint/format/diff checks attributed; no second whole-app/browser matrix. Source foundation ACK only. Existing Connect remains default; shared session/factory, native renderer/runtime qualification, release, and live operation approval remain separate. |
|
Qualified corrected SDK561 delta pushed at 94fc227 over source-ACK b240e04. Verified packed archive SHA256/SHA512; dependency/vendor/lock/docs plus removal of now-fixed SDK811 source-create fixture bridge only. pnpm verify PASS (format/types/strict lint/111 tests/build), frozen install PASS. Request clients narrow 7-path delta per coordinator; no second browser/native matrix or runtime switch. Integration remains next/new-sdk; this main-target PR is a review vehicle only. |
|
ACK 94fc227 Single-pass requested SDK561 delta: Delta only from b240: qualified561 pin, mechanical package/lock/provenance/docs and removal of the obsolete MemoryReplica create.document fixture bridge. No implementation or runtime change. Owner frozen/111 verify, focused45 and actual project types attributed; no second matrix. Independent exact committed archive SHA256/SHA512, package/lock/provenance consistency and diff check PASS (638609 bytes, source561501d0). Evidence: .coord/scratch/clients-apps-sdk561-pin-check.json and the corresponding clients-*-sdk561-delta.diff. Source/package ACK only. No SDK814 intake, native-runtime/default-backend switch, main cutover, browser/LAB/custody or operation acceptance. No autonomous merge/deploy. |
|
Coordinator1742 authorised qualified SDK814 successor pin-only intake. Clean/pushed exact40ffb3bd8d0f13dd3f8c1841a2cd319e8793f8db over ACK94fc227; 6 package/lock/archive/metadata/docs paths only, app implementation/tests untouched. Archive8cbc82fb SHA256/SHA512 independently verified. Full pnpm verify111/tests/strictlint/format/types/build + frozen PASS. Request one clients pin-only delta pass, no re-review unchanged source. No runtime/People/ops/serving enablement; main PR review vehicle only. |
|
ACK 40ffb3b Single-pass requested SDK814 successor pin-only delta from prior ACKed SDK561 head. Exactly six package/lock/provenance/docs/archive add-delete paths; no app implementation/tests/session/lease/read/write/backend/UI change or helper-alias rewrite. Independent exact committed archive SHA256/SHA512, qualified8cbc source, package/lock/provenance coherence and diff PASS. Owner full checks/build/frozen installs attributed; no unchanged source re-review, SDK repack or new matrix. Existing source ACKs stand. Source/package only: not a native snapshot, People/native Files producer compatibility, per-app trust/origin/custody/operations, session/runtime/backend enablement or main cutover. Editor697 unchanged/no extra PR. Evidence .coord/scratch/clients-apps-sdk814-pin-check.json and clients-*-sdk814-pin.diff. |
|
Co1807 authorised batched qualified SDK816 pin-only update: exactdaca1d2c709e6138d15cece0b6e8fa28d5faf3cb over SDK814 ACK40ffb3b. Six pkg/lock/archive/metadata/docs paths only; app source/tests untouched. Qualified9ab SHA256ab4d…+SHA512 verified. Fullverify111/types/strictlint/format/build/frozen PASS. Request one clients pin-only pass, no unchanged-code re-review. Source/package only; no environment selection enabled, runtime/factory/People/cutover/deploy claim. |
|
ACK daca1d2 Single requested six-path SDK816 pin delta from the prior SDK814 ACK. Package/lock/docs/provenance and delete8cbc/add9ab archive only; no app source/tests/adapter/session/backend/UI/People/default-runtime change. Independently verified committed660679B archive SHA256/SHA512, exact source9ab provenance, package-lock paths and diff. Owner frozen/wholechecks/actualtypes/build evidence attributed, not repeated. Prior unchanged-code ACK stands; no new SDK/native/browser matrix, factory/People/nativeFiles producer qualification, runtime/main cutover or deployment authorization. |
* test pending popup completion lifecycle (local checkpoint) * Close owned Connect popup after SDK consent completes
Install the SDK563 dev archive and its original beta129 connect-protocol dependency (d765e675c3da) as ordinary file dependencies in vendor/, replacing the e519009a archive and the protocol718 dfc5 archive (also the pnpm override for the legacy Connect packages). SHA256/SHA512 match the release manifest. Dev intake, not release-qualified.
The entry now exposes assess(), configure() and connection displayName. PlannerSdk is the public structural MdbaseApplicationEntry. When the SDK reports setup_required the gate offers 'Set up TaskNotes Planner', which calls only application.configure() with the caller's signal; readiness is still taken from the SDK snapshot, never inferred. Test stand-ins gain the new members. Docs record the pin and the pending live singleton hookup.
Dev intake, not release-qualified. The public application entry types are unchanged from 563dc868; the archive adds SDK collection selection and files.grant.
The archive carries the live MdbaseConnect entry and the native runtime assets. It is a dev intake and not release-qualified.
plannerSdk() is the page's one MdbaseConnect, declared from the unchanged manifest. Builds with VITE_MDBASE_ENV=lab lazily render App over it, and other builds keep Connect because the SDK refuses production. The gate follows snapshot.selection: an unapproved or invalid link offers approval or chooseAnother, with no fallback. Vite keeps the SDK out of dev pre-bundling and emits ES workers. The production build is blocked inside the SDK bundle (an unshipped sqlite3-worker1.mjs).
Next accounts approve each record capability together with its file actions and refuse an authorization that omits them, so Private collection access was refused. Declare list, read, replace and move, which pair with collection.read and records.edit.
Vendor the dev SDK at 1629d11ee44ecdef02f3559c6a0c2a6251114ee4 (sha256 82d121ceb40022251eca6bc63c2a42c6ff2aba5b7029901da6e7434184229b7a), replacing d230034f. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at e00c1ff839d7f2db8c88cccc5e946d4714f77762 (sha256 5e61b34d6c66070487f29e8328669eca83daa5b897819ee35face31b58eeef39), replacing 1629d11e. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at af29edc960775e3a49899a1c27129116abc83589 (sha256 368d0f5758992dc611026690cb702ba40d781a4daa89e768236b6ed927aed7b1), replacing e00c1ff8. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at 12c28ef1ee0d0d3a9e02b663de7eae9eed4321cf (sha256 d027a42c644b1518201e3a1b176ae6581ad212a0e329eb056a37acf572b5c235), replacing af29edc9. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at 23a10ee45149a0c84a786a3e0cab882be3b655b8 (sha256 ca83734ce0c3a1836f3fa5c07dad2ee493b306e50d0bdee997087a0f92adcb09), replacing 12c28ef1. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at ca8f0682cdda81fc8530c501137784ee5d122267 (sha256 93c193c23441a5efff7347b48b7afb2ba9345ab0112311d8f56b085da0d2e44a), replacing 23a10ee4. Native runtime b52b152b320b (was 3b3ca2eb4108); bundled protocol unchanged.
Vendor the dev SDK at abc08f3e9e78a87a7fe7c418a183fe8128988657 (sha256 4e76945db7f77c0c092e666cffdc028cad2dec775e7087fef228af77e8a9affe), replacing ca8f0682. Native runtime 8d18760c3a09 (was b52b152b320b); bundled protocol unchanged.
Vendor the dev SDK at e4450c267c8ab68f7b64faa34e8ed8ee098dbd5c (sha256 57d81d95201004d70c5cc9e65f05f1f33accaf78e15d86bdda15533d1f214ae2), replacing abc08f3e. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at 3491a619ed8ecb5d27b71af8f725771b1eafa5cb (sha256 513f40611711107487b0002633110829a4f05a71c3a41b96721686a08d5469c7), replacing e4450c26. Native runtime 965963fc2944 (was 8d18760c3a09); bundled protocol unchanged.
Vendor the dev SDK at 6f2b1e5141c3e93b8526c8207cdfc821d98ecdfd (sha256 4b45c3392a017781404e81ba3e8216e02c76c87fc1c21b0c7ac770a81252da53), replacing 3491a619. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at 4c10b9a50322f96d79bcac99bb790816541292a3 (sha256 a95ff466a60636be5e72d71901ebc39e4f3aeb15cabb588ca294a85c9525de10), replacing 6f2b1e51. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at 5c7b9592cc59b49f304f6bc63e5bf25c71701376 (sha256 369a7e15298c8fe90a1be817cf6f1cf15f023fa069755fd58c588019d4f0a30e), replacing 4c10b9a5. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at 6f14ebe1f361d0f72d34b80fbe9746e50ac89737 (sha256 91f009ceb334d01427b8a9529393676bec2ee719dc1ca9e69f3d6a14c89708e1), replacing 5c7b9592. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at 0f5724efe20d66420cc78a412e8db62fc0c9b292 (sha256 59853f6b10c09c53a5c303a83311c293852c4730f3fbd4438ce6a3dec158a1eb), replacing 6f14ebe1. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at 106d36ffc6ae0c59a509229d5eaed00515b603bd (sha256 338ea5fc2ada5df3e5bbaad9cb3609a8d042776e5b6cd45ab93825303da40582), replacing 0f5724ef. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at f1aa67e3bba5d7a5223541fd8f843792e2eb72e2 (sha256 451acc80a17d1a4a9294e1a843d2f18aeeb13d47b8111a7684947511ea459ef0), replacing 106d36ff. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at bef3fe454ca3214b940b3549efcbe37c2765bc70 (sha256 9b995c83b8143bec71a3cbd0d1cb2669393e2278236a272722890a9504d19b7b), replacing f1aa67e3. Native runtime and bundled protocol unchanged.
Vendor the dev SDK at 3f417b6d941a42444f17568d7489071d23fcb141 (sha256 0c5f04c6adad67d747055ebe12963403e374aefde0999861d759f35e4e118ba6), replacing bef3fe45. Native runtime and bundled protocol unchanged.
Native SDK data-layer foundation; existing Connect session remains default. No new browser sign-in mode or deployment.
125f2d19c35160eb3f6524d5c8e263d3eb4d97c9fa227946fc40470490bb1751; SHA512/provenance verified. No #803 session or #807 bundle. Release1417 confirms this earlier data-only pin is outside the later #807 unsafe-session hold.Draft dependencies: shared SDK web sign-in/collection/setup composition, qualified native renderer runtime/trust (source #802 is merged), and session safety qualification. No per-app auth/setup/protocol shim. SDK #807/5ba session intake remains held; this change does not enable a browser/session path.
Checks:
pnpm verifyPASS (format/typecheck/lint/100 unit tests/production build), frozen-lockfile install PASS, isolated Chromium2/2 on48733 with CI=1/strict port/no reuse. AppBases results remain controlled fixtures; one source-create test explicitly bridges MemoryReplica ignoring create.document. Not LAB/native renderer/source-parser/sign-in evidence.Reviewer: clients. Coordinator owns this production-repo merge. See docs/new-sdk.md.