Repository navigation
feat(alerts): a gateway sends chosen fleet events to generic webhook destinations - #741
Merged
Merged
Conversation
V3RON
marked this pull request as ready for review
October 20, 2026 07:05
V3RON
added this pull request to stack #743
October 20, 2026 07:05
2 of 3 tasks
V3RON
added a commit
that referenced
this pull request
Oct 20, 2026
Closes #720 ### Status Implement: done (14/14 green) Review: round 2 clean, fix-check clean (R4 fixed in 3f6a9ac) Hardware: n/a Gate: waiting for the stack Next: none until #718, #741 and this PR merge with the stack ## Done when - [ ] CI is green on the final head. - [x] A Slack destination receives the eleven events as `{"text": ...}` posts with Slack-escaped worker text (`alerts.test.ts`, the Slack format cases). - [x] `docs/CONFIGURATION.md` describes the Slack body and headers, scoped to Slack destinations. ## Assumptions - None. ## Review Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 3 blocking, 3 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 0 notes. Rounds: 2. Tokens: 5.6M. Runs: 13. Cost USD: 3.8631. Agent seconds: 2569. Assessment: complete *Written by an agent.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #719
Status
Implement: done (22/22 green) Review: round 2 clean, 3 blocking fixed in round 1 and 1 CI fix Hardware: n/a Gate: waiting for the stack
Next: none until #718 and this PR merge with the stack
Done when
alerts-imports-bus-ports-core-onlyandnot-alerts(.dependency-cruiser.mjs).worker.connectedfrom a gateway with agenericdestination (gateway-fleet.e2e.test.ts, "a worker joining a gateway with a generic destination ...").simlock config set gateway.alerts.destinations '[...http://n8n.internal/hook...]'prints the URL error and exits 2 (config.test.ts, "loadConfig refuses a bad url ...").docs/CONFIGURATION.mddocuments every field, the URL rule, the eleven events, the headers, the signature check and the retry rule (new "Alerts" section).Assumptions
Assumption:
workerLabelforAlertFormatDefinition.build—createAlertshas no such option in the spec, so it passes the id through unchanged;genericdoes not use it, and A gateway sends fleet events to Slack #720 supplies the real function.Open: the e2e "worker posts nothing" case cannot fail today, since a worker has no way to receive a poster; the claim holds by construction in
main.ts.Review
Spec review: 1 blocking, 1 fixed, 0 notes. Code review: 2 blocking, 2 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 2. Tokens: 3.5M.
Runs: 13. Cost USD: 6.3443. Agent seconds: 3517.
Assessment: complete
Written by an agent.