Repository navigation
Conversation
V3RON
marked this pull request as ready for review
October 19, 2026 00:41
V3RON
added this pull request to stack #691
October 19, 2026 00:41
Contributor
Author
Review notesNot blocking, not verified. Each is one reviewer's claim.
Written by an agent. |
This was referenced Oct 19, 2026
V3RON
added a commit
that referenced
this pull request
Oct 19, 2026
…stats and console figures (#623) (#626) Delivers #623: the event history moves to `history.db`, with usage projections, `simlock stats`, `GET /v1/stats` and the console's figures. It also includes ADR 0032. This PR carries the whole feature. The stack's PRs were reviewed one by one, and then a stack sync pushed every branch to one commit. GitHub then marked them as merged into each other, never into `main`. Their reviews stay there: - ADR 0032 (this PR) - #635 → #690 - #636 → #692 - #637 → #693 - #629 → #694 - #630 → #695 - #631 → #711 - #632 → #724 - #633 → #727 - #634 → #731 After the sync onto `main`, a fix-check reviewed the conflict resolutions. Its fix makes `history.db` and its WAL/SHM files owner-only (0600), as #685 did for `events.jsonl`. Closes #629, closes #630, closes #631, closes #632, closes #633, closes #634, closes #635, closes #636, closes #637. ### Status Implement: done Review: per-task PRs passed; sync fix-check passed Hardware: n/a Gate: running ## Review Spec review: skipped. Code review: 4 blocking, 4 fixed, 1 notes. Claims review: 0 blocking, 0 fixed, 0 notes. Rounds: 1. Tokens: 29.0M. *Written by an agent.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #629
Status
Implement: done Review: passed (round 2) Hardware: n/a Gate: waiting for the stack
Assumptions
-walor-shmfile — each file keeps its own name plus.damaged-<now>(history.db-wal.damaged-<now>), the reading of "each to<name>.damaged-<now>" that needs no new naming rule.NodeSqliteOpener.openthrowsSqliteUnavailableErrorfor a failed load; any other throw fromopenis damage.status.gethistoryfield stays optional in the schema — making it required breaks about a hundred existing status fixtures in contract, gateway and CLI tests that the spec does not touch; every daemon of this protocol sends it, and the CLI prints no History line when it is absent.a file whose quick_check answers something but okexpects only the later event in the fresh file, and the daemon test needsdaemon.started, emitted while the set-aside awaits.replayback to the ring, but a projection that throws (a clean rollback) leaves the file readable, soreplaystill reads it — the red testsa projection that throws leaves neither…and the conformance suite expect the file's rows after a projection failure,replays the ring with sinceTs once writing has stoppedexpects the ring after an insert failure.HISTORY_PROJECTIONSis also exported fromsrc/history/index.ts— the boundary rule lets the daemon import only a component's index, and the host has to hand the registry in.simlock statusprints noHistory:line — before the socket claim the history is not yet started, sowriting: falsewould read as a fault;--jsoncarrieshistoryin that answer.simlock config setwriteseventLogas{}whenrotateByteswas its only key, rather than deleting the block.Review
Spec review: 2 blocking, 1 fixed, 1 notes. Code review: 3 blocking, 3 fixed, 0 notes. Claims review: 2 blocking, 2 fixed, 3 notes.
Rounds: 2. Tokens: 30.3M.
Assessment: complete
Fixed unreviewed (text, rule 14):
src/contract/AGENTS.md:8Imported by (0c1a557).Rejected:
Written by an agent.