Repository navigation
Conversation
33 failing -> 0 failing (unit)
…ouches (#635) 0 failing
Document the cause in the core manual's quarantine step, restore unrelated Known gaps wording, and cover the not-quarantined guard of the Cause fact.
V3RON
marked this pull request as ready for review
October 18, 2026 16:34
V3RON
added this pull request to stack #691
October 18, 2026 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #635
Status
Implement: done Review: passed (round 2) Hardware: n/a Gate: waiting for the stack
Done when
Purge failed: <message>in the Attention inspector andquarantineCauseinsimlock status --json, before and aftersimlock daemon stopandstart(the e2e line).src/core/AGENTS.mdKnown gaps has the rollback gap (item 11).docs/CLI.md,docs/HTTP-API.md,docs/CONSOLE.md,docs/EVENTS.mdanddocs/internal/EVENTS.mddescribe the cause and the new payload fields.Assumptions
src/http/app.test.tsruns on a fake dispatcher that cannot strip the message, so the operator/agent token test runs throughstartDaemoninsrc/daemon/main.test.ts(real dispatcher, real HTTP gateway) instead.Registryin a newdescribeinquarantine-coordinator.test.ts, because the file'sFakeRegistrywould only echo what the test wrote.quarantine-coordinator.test.ts—enterFromStalledTransitionnow needs the finding's state, so those tests start the target device in that state and pass it, rather than startingquarantined.registry.test.tsphysical-only state files lackeddevices: [], which the loader requires; added it to the test data, no assertion changed.39in four existing tests (server.test.ts,daemon-protocol/index.test.ts,service.test.ts) — mechanical.runCligets afallow-ignore complexityline; its complexity is from the base, not this task, and Fallow audits every function of a changed file.Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 2 blocking, 2 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 2. Tokens: 3.8M.
Assessment: complete
Written by an agent.