Skip to content

feat(gyp-to-cmake): translate ldflags to CMake link options - #480

Open
KeuqS wants to merge 1 commit into
callstackincubator:nextfrom
KeuqS:fix/100-ldflags
Open

KeuqS wants to merge 1 commit into
callstackincubator:nextfrom
KeuqS:fix/100-ldflags

Conversation

@KeuqS

@KeuqS KeuqS commented Oct 13, 2026

Copy link
Copy Markdown

Summary

  • Add `ldflags` to the validated `binding.gyp` target shape.
  • Translate target-level `ldflags` to private CMake `target_link_options`.
  • Preserve command expansion and escaped spaces, matching the existing `cflags` behavior.
  • Add a package changeset.

Closes #100

How I tested this

  • `tsx --test packages/gyp-to-cmake/src/gyp.test.ts packages/gyp-to-cmake/src/transformer.test.ts` (23 tests passed)
  • `tsc -p packages/cli-utils/tsconfig.json`
  • `tsc -p packages/gyp-to-cmake/tsconfig.json`
  • Prettier check on all changed source and test files
  • `git diff --check`

The local pnpm runtime is newer than this repository's pinned pnpm version and stops on its ignored third-party build-script safety check. I ran the package tests and TypeScript builds directly with the installed local tools instead; all relevant checks passed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve gyp-to-cmake to handle "ldflags"

1 participant