Skip to content

feat(gyp-to-cmake): support linker flags - #476

Merged
kraenhansen merged 1 commit into
callstackincubator:mainfrom
KeuqS:fix/100-gyp-ldflags
Oct 13, 2026
Merged

kraenhansen merged 1 commit into
callstackincubator:mainfrom
KeuqS:fix/100-gyp-ldflags

Conversation

@KeuqS

@KeuqS KeuqS commented Oct 12, 2026

Copy link
Copy Markdown

Summary

  • add ldflags to the parsed GYP target model and validate its shape
  • emit target_link_options for target-specific linker flags
  • support the same command expansion and escaping behavior as cflags
  • add parser and transformer coverage, including command expansions

Fixes #100

Validation

  • gyp-to-cmake focused tests: 23 passed
  • TypeScript build for cli-utils and gyp-to-cmake: passed
  • ESLint on changed files: passed
  • Prettier check on changed files: passed
  • git diff --check: passed

@kraenhansen
kraenhansen changed the base branch from next to main October 13, 2026 07:48
@kraenhansen

kraenhansen commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

Retargeted to main and rebased onto it, since this gyp-to-cmake change doesn't depend on next (@KeuqS: I force-pushed your branch, so git reset --hard origin/fix/100-gyp-ldflags before pushing again).

@kraenhansen kraenhansen self-assigned this Oct 13, 2026
@kraenhansen
kraenhansen merged commit 1e55b7a into callstackincubator:main Oct 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve gyp-to-cmake to handle "ldflags"

3 participants