Repository navigation
Isolate plist reading and writing in the host's plist module - #474
Merged
Merged
Conversation
Move readAndParsePlist into its own module and export it from the Node.js entrypoint, so verify-prebuilds can use it instead of its own copy. Keeping it out of cli/apple.ts avoids loading @bacons/xcode and the CLI utilities from the package's main entrypoint. Closes #472 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Moves the XML write helper out of prebuilds/apple.ts into plist.ts as writePlist, and uses it for the two Info.plist writers in cli/apple.ts, so plist.ts is the only module importing @expo/plist or bplist-parser. readAndParsePlist's assertion now says "a plist", as it reads any plist. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
kraenhansen
marked this pull request as ready for review
October 12, 2026 21:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #472.
bplist-parsersupport inreadAndParsePlistalready landed in 14e5119; this does the remaining part of the issue — sharing it withverify-prebuilds— and isolates plist handling so@expo/plistandbplist-parserare easier to update.readAndParsePlistmoves intopackages/host/src/node/plist.tsand is exported from the Node.js entrypoint (not fromcli/apple.ts, which would make the entrypoint load@bacons/xcodeand the CLI utilities).verify-prebuilds.mtsuses it instead of its own copy, andnode-addon-examplesdrops its@expo/plistandbplist-parserdevDependencies.prebuilds/apple.tsmoves alongside it aswritePlist(internal) and also backs the twoInfo.plistwriters incli/apple.ts.plist.tsis now the only module importing either library.plist.tsis format-only;Info.plistsemantics stay with the callers' zod schemas.readAndParsePliststill returnsunknown— callers validate.Test plan
pnpm run build,lint,prettier:check; host tests (67) and cmake-rn tests (16)arm64;x86_64-apple-ios-simand ranverify: 13 prebuilds verified, reading binary plists through the shared helpercreateAppleFrameworkon a test dylib (flat and versioned): both write the expected XMLInfo.plistthroughwritePlist🤖 Generated with Claude Code