Repository navigation
cmake-rn: honor CODE_SIGNING_ALLOWED for framework targets - #473
Merged
Merged
Conversation
#430 only passed CODE_SIGNING_ALLOWED to the `cmake --build` used for plain dynamic libraries; the `xcodebuild archive`/`install` calls for CMake FRAMEWORK targets kept signing, leaving a _CodeSignature directory in each. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
kraenhansen
added
the
Apple 🍎
kraenhansen
marked this pull request as ready for review
October 11, 2026 21:36
Collaborator
Author
|
Merged this without green CI (YOLO) as I'm shutting down now and want to rebase #426 on this before I do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#430 made
CODE_SIGNING_ALLOWEDconfigurable, but only passed it to thecmake --buildused for plain dynamic libraries. CMakeFRAMEWORK TRUEtargets (which is whatgyp-to-cmakeemits) are built throughxcodebuild archive/install, which kept signing — so every framework in the examples' xcframeworks had a_CodeSignaturedirectory. Found while makingverify-prebuildsrun against real build output in #426.Test plan
pnpm run build,lint,prettier:check, cmake-rn testsCMAKE_RN_TRIPLETS="arm64;x86_64-apple-ios-sim": no_CodeSignatureleft in any framework (was present in all before)🤖 Generated with Claude Code