Two test gaps: unverified prebuild Info.plist and a missing .node fixture in the Babel plugin tests #424

Two TODOs marked tests that asserted less than they appeared to. Both are now fixed on main and next.

verify-prebuilds skipped the Info.plist it just found

packages/node-addon-examples/scripts/verify-prebuilds.mts walked each framework in the XCFramework and continued past Info.plist without reading it. That file is written by writeFrameworkInfoPlist in packages/host/src/node/prebuilds/apple.ts, and a wrong CFBundleExecutable or CFBundleIdentifier passes every build step and then fails at load time on device. The script now validates Info.plist with a zod schema.

"does not touch required JS files" didn't prove what it claimed

The fixture in packages/host/src/node/babel-plugin/plugin.test.ts had my-addon.js but no sibling my-addon.node, so the assertion passed for the wrong reason. Completing the fixture exposed a real bug: isNodeApiModule in packages/host/src/node/path-utils.ts accepted an existing <path>.node before considering a .js/.json file beside it, so require('./my-addon') was rewritten to requireNodeAddon(...). The .js/.json-before-.node precedence now lives in isNodeApiModule and the plugin test has the sibling addon.

Resolution

Fixed by #426 (8d125fa), released via #471, and merged from main into next, where neither TODO remains. The competing implementations (#467 and earlier attempts) are closed.