Repository navigation
Cranelift: fix Windows unwind info. - #14643
Merged
Merged
Conversation
Fixes two separate issues: - Scale factor for SaveReg should be 8, not 16; the encoded offset was off by a factor of two. - We need to emit a StackAlloc op to align the implicit frame with reality. The unwind info is not correctness-critical for Wasmtime (we have our own unwinder) but could matter for native debugging or profiling on Windows systems.
alexcrichton
approved these changes
Oct 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 10, 2026
github-actions
Bot
added
the
cranelift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two separate issues:
The unwind info is not correctness-critical for Wasmtime (we have our own unwinder) but could matter for native debugging or profiling on Windows systems.