Repository navigation
Cranelift: fix unwind info around tail calls. - #14642
Merged
Merged
Conversation
While Wasmtime doesn't use the DWARF unwind info / frame definitions, it is still useful to try to get them to be as correct as possible, because native debugging and especially native profiling (`perf record`, `samply`, etc) use this info. Previously, the definition of the CFA did not quite stay in sync with a valid frame when we move the frame due to a resizing argument area on tail-calls. This PR reworks the metadata to instead define the CFA in terms of the FP and leave FP unchanged until we switch to the new frame.
alexcrichton
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While Wasmtime doesn't use the DWARF unwind info / frame definitions, it is still useful to try to get them to be as correct as possible, because native debugging and especially native profiling (
perf record,samply, etc) use this info.Previously, the definition of the CFA did not quite stay in sync with a valid frame when we move the frame due to a resizing argument area on tail-calls. This PR reworks the metadata to instead define the CFA in terms of the FP and leave FP unchanged until we switch to the new frame.