Repository navigation
Wake up more waiters on waitable-sets - #14638
Merged
alexcrichton merged 1 commit intoOct 10, 2026
Merged
Conversation
When an event is delivered to a waitable set technically any thread in that set is candidate for receiving the event, but prior to this commit Wasmtime would only ever deliver the event to one arbitrary thread in the set. This caused issues when that thread cannot run due to the instance's lock being held, meaning that other candidate threads couldn't run to completion and actually get the event. This commit handles this situation by waking up other threads in in this situation. Only one thread will still get the event, and others go back to sleep if it's stolen.
dicej
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an event is delivered to a waitable set technically any thread in that set is candidate for receiving the event, but prior to this commit Wasmtime would only ever deliver the event to one arbitrary thread in the set. This caused issues when that thread cannot run due to the instance's lock being held, meaning that other candidate threads couldn't run to completion and actually get the event. This commit handles this situation by waking up other threads in in this situation. Only one thread will still get the event, and others go back to sleep if it's stolen.