Repository navigation
Fix libelf detection in the 32 bit Linux CI build - #592
Merged
Merged
Conversation
Collaborator
|
Looks good apart from the commit comment: "CI comments in English". Can you make it the same as the PR description and force-push? Or I can do it while merging. Thanks, G |
felias-fogg
force-pushed
the
fix-lin32-libelf
branch
from
October 12, 2026 17:32
fb41175 to
a472894
Compare
Contributor
Author
Done. Cheers, |
Collaborator
|
Perhaps irrelevant now but about: "The 32 bit Linux build has no ELF support, so the binary it produces cannot load any firmware at all:". Hex firmware files should have still worked. You just have to ask Make for the hex ... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 32 bit Linux build has no ELF support, so the binary it produces cannot load any firmware at all:
The reason is in the Install Dependencies step of
build-lin32. Adding the i386 architecture makes apt remove 206 amd64 packages to resolve the dependencies, andpkgconfis one of them.Makefile.commondetects libelf withpkg-config, so from then onHAVE_LIBELFstays undefined andsim_elf.ccompiles to the stub that prints the message above.It went unnoticed, as far as I can tell, because
build-lin32is the only job withoutmake run_tests. I have the fix running green in my fork, where I load a small firmware after each build as a smoke test, on all eight platforms.