Repository navigation
Fix off-by-one error on valid I/O addresses - #590
Merged
Merged
Conversation
The range of valid I/O addresses is 32..MAX_IOs+31.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
sim_core.c, there are two instances where an address is determined to be a valid I/O address with this test:However, the range of valid I/O addresses is 32 – (
MAX_IOs+31) inclusive. Thus, the upper bound in the above test should be included.This pull request fixes the error. This could be done by replacing
<with<=in the second comparison. Instead, I chose to writebecause:
index ranges defined as left-closed, right-open intervals, like [a, b), are more idiomatic in C than their reversed counterparts
this is stylistically more consistent with the test
if (addr < MAX_IOs + 32)in_avr_set_ram().