Repository navigation
Run pinned job plans on macOS and Windows - #72
Merged
Merged
Conversation
Preserve native setup and accept digest-bound inline plans and events without changing the runtime ABI. Amp-Thread-ID: https://ampcode.com/threads/T-3784262c-5fe0-4e2f-99ad-8443940d75a8 Co-authored-by: Amp <amp@ampcode.com>
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
Accept the bound proof repository and separate event payload source. Use the installed base64 path in portable tests. Amp-Thread-ID: https://ampcode.com/threads/T-3784262c-5fe0-4e2f-99ad-8443940d75a8 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-3784262c-5fe0-4e2f-99ad-8443940d75a8 Co-authored-by: Amp <amp@ampcode.com>
Restore the agent umask before creating host directories. Exercise the native Namespace target in scheduled platform proofs. Amp-Thread-ID: https://ampcode.com/threads/T-3784262c-5fe0-4e2f-99ad-8443940d75a8 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-3784262c-5fe0-4e2f-99ad-8443940d75a8 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-3784262c-5fe0-4e2f-99ad-8443940d75a8 Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 52384, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
buildsworth-bk-app
Bot
dismissed
their stale review
November 11, 2026 07:45
Superseded by a newer Buildsworth review.
Amp-Thread-ID: https://ampcode.com/threads/T-3784262c-5fe0-4e2f-99ad-8443940d75a8 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Why
run.runtime.platform: darwin/arm64andwindows/amd64cannot use the pinned launcher. Server-side producers also need to deliver a plan without an importer job or a local file.What
Run pinned plans on all four released platforms, keeping Linux runner setup, macOS's current user and tool cache, and native Windows execution. Namespace images retain their PATH, hostname and Docker behavior.
Plan sources are exclusive: inline bytes, a local path, or an exact producer UUID. Events can use inline bytes or the existing separate payload variable; both are checked against the verified plan and published by the real execution job. The runtime API stays unchanged.
The importer advertises expanded launcher support explicitly so newer CLIs can preserve legacy delivery for older plugin pins. This plugin must ship before importers select the expanded contract. Opt-in native-agent proofs exercise released runtimes and normal plugin installation; they deliberately replace legacy delivery for this consumer gate, not claim unchanged importer emission.