Skip to content

fix(release): version Effect adapter independently - #348

Merged
btravers merged 1 commit into
mainfrom
fix/independent-effect-releases
Oct 19, 2026
Merged

btravers merged 1 commit into
mainfrom
fix/independent-effect-releases

Conversation

@btravers

@btravers btravers commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

The Effect 4 migration currently causes release PR #347 to bump unthrown and its fixed version group to 6.0.0.

Remove @unthrown/effect from the Changesets fixed group so its breaking upgrade can release as 6.0.0 independently while unthrown stays on 5.x. Keep the adapter's major changeset and document its independent versioning in CONTRIBUTING.md. Once merged, the release workflow can regenerate #347.

Validation: release configuration assertions and git diff --check passed. Full Changesets validation could not run because dependency installation was blocked by missing offline registry metadata. Commit hooks reported that Lefthook was unavailable.

Summary by CodeRabbit

  • Documentation
    • Clarified that @unthrown/effect and adapters outside the fixed package group are versioned independently.
    • Updated beta pre-release guidance to remove the previous explanation for why @unthrown/prisma and @unthrown/orpc were outside the group.
  • Release Management
    • @unthrown/effect is no longer included in the fixed package group.

Copilot AI balanced review requested due to automatic review settings October 19, 2026 07:55
@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: btravstack/unthrown/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 39cbdcd4-f0f3-4e89-b315-b8f5e1c6195d
📥 Commits

Reviewing files that changed from the base of the PR and between 7211584 and a5add9c.

📒 Files selected for processing: 2
  • .changeset/config.json
  • CONTRIBUTING.md
+-----------------------------------------------+
| Optimization hinders evolution. - Alan Perlis |
+-----------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T07:56:59.927154Z a5add9c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

It alters monorepo release/versioning governance that drives npm publishing, and the author noted the full Changesets validation could not be run, so a human should confirm the resulting version plan.

No open issues 🎉

What changed in this PR

This PR decouples @unthrown/effect from the Changesets fixed version group so its breaking Effect 4 migration can release as 6.0.0 independently, rather than dragging unthrown and the rest of the family to a 6.0.0 major. It targets the problem seen in release PR #347, where the shared fixed group forced all eight members up to 6.0.0 purely because of the Effect adapter's major changeset.

Changes:

  • Remove @unthrown/effect from the fixed array in .changeset/config.json, leaving seven packages locked together.
  • Update CONTRIBUTING.md to document that @unthrown/effect (and other non-group adapters) are versioned independently.
  • The adapter's existing major changeset (.changeset/effect-four-interop.md) is retained so Effect alone bumps to 6.0.0.
File Description
.changeset/​config.json Removes @unthrown/effect from the fixed group (now 7 packages) so it versions independently.
CONTRIBUTING.md Replaces the prisma/orpc parenthetical with a note that @unthrown/effect and other out-of-group adapters version independently; "seven packages" now matches the config.

Notes for the author (no blocking issues found in the diff):

  • The CONTRIBUTING.md "seven packages in the fixed group" count is now accurate (the group contains exactly 7 entries). It was previously off by one (8 members), so this change incidentally corrects that.
  • The authoritative spec CLAUDE.md lists prisma/drizzle/orpc/pothos as "Outside the fixed version group" but still does not note @unthrown/effect as outside it (the packages/effect bullet around lines 900–901). That file is outside this PR's scope, but consider updating it in the same change to keep the spec in sync.

Review effort: Balanced

@btravers
btravers merged commit efb245a into main Oct 19, 2026
15 of 16 checks passed
@btravers
btravers deleted the fix/independent-effect-releases branch October 19, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants