Repository navigation
fix(release): version Effect adapter independently - #348
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 2
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🔵 Needs a closer look
It alters monorepo release/versioning governance that drives npm publishing, and the author noted the full Changesets validation could not be run, so a human should confirm the resulting version plan.
No open issues 🎉
What changed in this PR
This PR decouples @unthrown/effect from the Changesets fixed version group so its breaking Effect 4 migration can release as 6.0.0 independently, rather than dragging unthrown and the rest of the family to a 6.0.0 major. It targets the problem seen in release PR #347, where the shared fixed group forced all eight members up to 6.0.0 purely because of the Effect adapter's major changeset.
Changes:
- Remove
@unthrown/effectfrom thefixedarray in.changeset/config.json, leaving seven packages locked together. - Update
CONTRIBUTING.mdto document that@unthrown/effect(and other non-group adapters) are versioned independently. - The adapter's existing major changeset (
.changeset/effect-four-interop.md) is retained so Effect alone bumps to6.0.0.
| File | Description |
|---|---|
.changeset/config.json |
Removes @unthrown/effect from the fixed group (now 7 packages) so it versions independently. |
CONTRIBUTING.md |
Replaces the prisma/orpc parenthetical with a note that @unthrown/effect and other out-of-group adapters version independently; "seven packages" now matches the config. |
Notes for the author (no blocking issues found in the diff):
- The
CONTRIBUTING.md"seven packages in thefixedgroup" count is now accurate (the group contains exactly 7 entries). It was previously off by one (8 members), so this change incidentally corrects that. - The authoritative spec
CLAUDE.mdlists prisma/drizzle/orpc/pothos as "Outside the fixed version group" but still does not note@unthrown/effectas outside it (thepackages/effectbullet around lines 900–901). That file is outside this PR's scope, but consider updating it in the same change to keep the spec in sync.
Review effort: Balanced
The Effect 4 migration currently causes release PR #347 to bump
unthrownand its fixed version group to 6.0.0.Remove
@unthrown/effectfrom the Changesets fixed group so its breaking upgrade can release as 6.0.0 independently whileunthrownstays on 5.x. Keep the adapter's major changeset and document its independent versioning in CONTRIBUTING.md. Once merged, the release workflow can regenerate #347.Validation: release configuration assertions and
git diff --checkpassed. Full Changesets validation could not run because dependency installation was blocked by missing offline registry metadata. Commit hooks reported that Lefthook was unavailable.Summary by CodeRabbit
@unthrown/effectand adapters outside the fixed package group are versioned independently.@unthrown/prismaand@unthrown/orpcwere outside the group.@unthrown/effectis no longer included in the fixed package group.