Add opt-in Brainstore startup gate for API pods - #104
Merged
Alexey Soldatchenko (soldatchenko) merged 6 commits intoOct 2, 2026
Merged
Conversation
Alexey Soldatchenko (soldatchenko)
marked this pull request as ready for review
October 1, 2026 19:30
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-authored-by: Kevin Green <kevin.green@braintrust.dev>
Kevin Green (KevinGreen)
approved these changes
Oct 2, 2026
Comment on lines
+3
to
+4
| {{- $defaults := dict | ||
| "enabled" false |
Contributor
There was a problem hiding this comment.
Suggested change
| {{- $defaults := dict | |
| "enabled" false | |
| {{- $defaults := dict | |
| "enabled" true |
I guess this might need to be bumped too?
Alexey Soldatchenko (soldatchenko)
deleted the
codex/brainstore-api-init-gate
branch
October 2, 2026 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helm can start a new API before Brainstore supports its query behavior. This adds an opt-in init container that waits for compatible Brainstore capacity, allowing a single Helm upgrade without customer-side sequencing steps.
Behavior
api.brainstoreStartupGate.enableddefaults tofalseand applies to every API pool.Requires stable release tags, API rolling updates with zero unavailable replicas and nonzero surge, sufficient surge capacity, and Kubernetes API access. Application owners must confirm the assumed release compatibility. Rollback sequencing is not covered; Brainstore downgrades can temporarily cause query errors.
Validation