improve bandpower calculations and cleanup data handling - #866
Andrey1994 wants to merge 4 commits into
Conversation
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f014dcce80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ${CMAKE_CURRENT_SOURCE_DIR}/src/data_handler/signal_processing.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/src/data_handler/signal_metrics.cpp | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/src/data_handler/decomposition.cpp |
There was a problem hiding this comment.
These three newly listed source files are absent from the commit, as is src/data_handler/inc/filter_helpers.h, which the changed data_handler.cpp now includes. Configuring the repository fails at this target with Cannot find source file .../signal_processing.cpp, and the implementations removed from data_handler.cpp therefore cannot be built on any platform. Commit the split implementation files and header along with these build changes.
Useful? React with 👍 / 👎.
| brainflow CONFIG REQUIRED | ||
| ) | ||
|
|
||
| add_executable (signal_processing_regression src/signal_processing_regression.cpp) |
There was a problem hiding this comment.
The repository tree contains no src/signal_processing_regression.cpp, so both Unix and Windows fail while configuring the signal-processing examples before this target can run. The new workflow steps likewise reference five absent Python scripts, an absent C# project, and an absent Java regression class, so merely fixing this C++ source still leaves both CI workflows guaranteed to fail; add the regression assets or remove their targets and invocations.
Useful? React with 👍 / 👎.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| switch (PlatformHelper.get_library_environment ()) | ||
| { | ||
| case LibraryEnvironment.x64: | ||
| return DataHandlerLibrary64.perform_inverse_wavelet_transform_checked (coeffs, coeff_count, original_data_len, wavelet, level, extension, lengths, lengths_count, output, output_count); |
| case LibraryEnvironment.x64: | ||
| return DataHandlerLibrary64.perform_inverse_wavelet_transform_checked (coeffs, coeff_count, original_data_len, wavelet, level, extension, lengths, lengths_count, output, output_count); | ||
| case LibraryEnvironment.x86: | ||
| return DataHandlerLibrary32.perform_inverse_wavelet_transform_checked (coeffs, coeff_count, original_data_len, wavelet, level, extension, lengths, lengths_count, output, output_count); |
| [DllImport ("DataHandler", SetLastError = true, CallingConvention = CallingConvention.Cdecl)] | ||
| public static extern int perform_wavelet_transform (double[] data, int data_len, int wavelet, int decomposition_level, int extension, double[] output_data, int[] decomposition_lengths); | ||
| [DllImport ("DataHandler", SetLastError = true, CallingConvention = CallingConvention.Cdecl)] | ||
| public static extern int perform_inverse_wavelet_transform_checked (double[] coeffs, int coeff_count, int original_data_len, int wavelet, int level, int extension, int[] lengths, int lengths_count, double[] output, int output_count); |
| [DllImport ("DataHandler32", SetLastError = true, CallingConvention = CallingConvention.Cdecl)] | ||
| public static extern int perform_wavelet_transform (double[] data, int data_len, int wavelet, int decomposition_level, int extension, double[] output_data, int[] decomposition_lengths); | ||
| [DllImport ("DataHandler32", SetLastError = true, CallingConvention = CallingConvention.Cdecl)] | ||
| public static extern int perform_inverse_wavelet_transform_checked (double[] coeffs, int coeff_count, int original_data_len, int wavelet, int level, int extension, int[] lengths, int lengths_count, double[] output, int output_count); |
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
| import re | ||
| import sys | ||
| import tempfile | ||
| import unittest |
| if selected_board is None and len(parts) >= 3: | ||
| try: | ||
| selected_board = int(parts[-2]) | ||
| except ValueError: |
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
Signed-off-by: Andrey Parfenov <a1994ndrey@gmail.com>
This branch has not been deployed
1 participant
No description provided.