Repository navigation
fix: preserve library context in plugin settings - #35
Merged
Merged
Conversation
Use Calibre's loaded interface action when Preferences opens the plugin configuration without an explicit action. Apply the same context to the config_widget hook. Add regression tests for column discovery, mapping preservation, explicit-action precedence, and cancellation. Fixes #34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Calibre's Preferences → Plugins → Customize entry point calls
do_user_config()with only the parent GUI. Unlike the toolbar entry point, it does not pass the running plugin action. This left every column dropdown at “(Not mapped)” and could erase all eight saved mappings when the dialog was accepted.config_widget()hook as well.Type of change
Verification
config_widget()column discovery, and Preferences mapping preservation); the toolbar and cancellation cases passed.HEADbefore this commit.Checklist
Related issues
Fixes #34
Reporter workaround: #1 (comment)