Repository navigation
kernel-6.18, kmods: sign modules with the kit module-signing key - #601
Draft
michaelb990 wants to merge 3 commits into
Draft
michaelb990 wants to merge 3 commits into
michaelb990 wants to merge 3 commits into
Conversation
michaelb990
force-pushed
the
module-signing
branch
3 times, most recently
from
October 28, 2026 00:00
a4573fc to
47173e9
Compare
This was referenced Oct 28, 2026
Build Twoliter from michaelb990/twoliter at the module-signing branch, which creates a kit module-signing key for packages that set module-signing = true. Replace this with the Twoliter release that carries it before merging. Signed-off-by: Michael Brown <brownxmi@amazon.com>
Set module-signing = true for kernel-6.18, kmod-6.18-efa and
kmod-6.18-nvidia-r580, so Twoliter mounts one kit module-signing key
for these three package builds.
kernel-6.18 passes the key, %{_cross_module_signing_key}, to every make
as CONFIG_MODULE_SIG_KEY, so Kbuild signs the in-tree and Neuron
modules with the kit key and builds its certificate in as the only
built-in key, instead of generating a key of its own. A new
kernel-6.18-module-signature-enforcement subpackage ships the public
certificate as kit-cert.pem with a boot config snippet that sets
module.sig_enforce=1 and lockdown=integrity.
The SDK's sign-kernel-modules buildroot policy signs the modules that
kmod-6.18-efa and kmod-6.18-nvidia-r580 install: efa.ko, the open GPU
modules, the GRID modules built from the GRID driver's kernel-open
tree, and gdrdrv. Twoliter defines %_cross_module_signing_key for the
three builds; the policy needs a Bottlerocket SDK release that has it.
Signed-off-by: Michael Brown <brownxmi@amazon.com>
Extend the check that H100 is in the open-driver device list to H200, B200 and B300 on x86_64 and to GB200 and GB300 on aarch64, so the build fails if a driver update moves any of them off the open driver. Signed-off-by: Michael Brown <brownxmi@amazon.com>
michaelb990
force-pushed
the
module-signing
branch
from
October 28, 2026 00:16
47173e9 to
f20be4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Sign every module built by
kernel-6.18,kmod-6.18-efaandkmod-6.18-nvidia-r580with the kit module-signing key from bottlerocket-os/twoliter#764.Draft: this depends on bottlerocket-os/twoliter#764, which mounts the key and defines
%_cross_module_signing_key, and on a Bottlerocket SDK release with bottlerocket-os/bottlerocket-sdk#398, which adds thesign-kernel-modulesbuildroot policy. The first commit builds Twoliter from the #764 branch so CI can run, and will be replaced with the Twoliter release; the SDK pin moves to the SDK release.module-signing = true, so Twoliter mounts one key per kit build for these three package builds only.kernel-6.18passes the key,%{_cross_module_signing_key}(defined by Twoliter), to everymakeasCONFIG_MODULE_SIG_KEY, so Kbuild signs the in-tree and Neuron modules with it and builds its certificate in as the only built-in key, instead of generating a key of its own.kernel-6.18-module-signature-enforcementsubpackage ships the certificate as/usr/share/bottlerocket/module-signing/kit-cert.pemand a boot config snippet that setsmodule.sig_enforce=1andlockdown=integrity. Nothing pulls it in; variants that want enforcement add it toincluded-packages.sign-kernel-modulesbuildroot policy signs the modules they install (efa.ko; the open GPU modules, the GRID modules built from the GRID driver'skernel-opentree, andgdrdrv). The proprietary driver ships as unlinked objects and is not signed.Other variants are unaffected beyond the change of signing key: the final kernel
.configand command line are unchanged.Commits:
DO NOT MERGE: build Twoliter from the module-signing branchkernel-6.18, kmods: sign modules with the kit module-signing keykmod-6.18-nvidia-r580: check more GPUs keep the open driverTesting done:
efa.ko, five open GPU, five GRID,gdrdrv).aws-mantle-1x86_64 image built from that kit, with the subpackage added and the two switches inkernel-parameters(the snippet needs Remove kernel cmdline hardcoding and enable PCR calculations for UKI twoliter#745 to reach the UKI command line), on m7i.large with Secure Boot:module.sig_enforceisY, lockdown is[integrity];.builtin_trusted_keysholds only the kit key;insmodofdummy.kowithout its signature, and signed by an untrusted key, are both rejected ("Key was rejected by service"); the kit-signeddummy.koloads; taint stays 0.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.