Skip to content

remove boost assert from include/boost/graph/vf2_sub_graph_iso.hpp #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Becheler merged 4 commits into from
Nov 1, 2026
Merged

remove boost assert from include/boost/graph/vf2_sub_graph_iso.hpp #684

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79d6830
remove boost assert
andreacassioli Oct 31, 2026
9ee56ca
reintroduce assert remove by mistake
andreacassioli Oct 31, 2026
c2a3dc8
Merge remote-tracking branch 'origin/develop' into remove-boost-asser…
andreacassioli Nov 1, 2026
a9415d4
restore include
andreacassioli Nov 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions include/boost/graph/vf2_sub_graph_iso.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#define BOOST_VF2_SUB_GRAPH_ISO_HPP

#include <iostream>
#include <iomanip>
#include <iterator>
#include <vector>
#include <utility>
Expand Down Expand Up @@ -953,15 +952,15 @@ namespace detail
(ReadablePropertyMapConcept< IndexMapSmall, vertex_small_type >));
typedef typename property_traits< IndexMapSmall >::value_type
IndexMapSmallValue;
BOOST_STATIC_ASSERT(
(is_convertible< IndexMapSmallValue, size_type_small >::value));

static_assert(
std::is_convertible< IndexMapSmallValue, size_type_small >::value, "The value type of the index map of the small graph must be convertible to the vertices size type of the same graph.");
BOOST_CONCEPT_ASSERT(
(ReadablePropertyMapConcept< IndexMapLarge, vertex_large_type >));
typedef typename property_traits< IndexMapLarge >::value_type
IndexMapLargeValue;
BOOST_STATIC_ASSERT(
(is_convertible< IndexMapLargeValue, size_type_large >::value));
static_assert(
std::is_convertible< IndexMapLargeValue, size_type_large >::value, "The value type of the index map of the large graph must be convertible to the vertices size type of the same graph.");

// Edge & vertex requirements
typedef typename graph_traits< GraphSmall >::edge_descriptor
Expand All @@ -979,8 +978,8 @@ namespace detail
// Vertex order requirements
BOOST_CONCEPT_ASSERT((ContainerConcept< VertexOrderSmall >));
typedef typename VertexOrderSmall::value_type order_value_type;
BOOST_STATIC_ASSERT(
(is_same< vertex_small_type, order_value_type >::value));
static_assert(std::is_same< vertex_small_type, order_value_type >::value, "The vertex type of the small graph must be the same as the order value type.");

BOOST_ASSERT(num_vertices(graph_small) == vertex_order_small.size());

if (num_vertices(graph_small) > num_vertices(graph_large))
Expand Down Expand Up @@ -1165,12 +1164,13 @@ bool vf2_graph_iso(const Graph1& graph1, const Graph2& graph2,
BOOST_CONCEPT_ASSERT(
(ReadablePropertyMapConcept< IndexMap1, vertex1_type >));
typedef typename property_traits< IndexMap1 >::value_type IndexMap1Value;
BOOST_STATIC_ASSERT((is_convertible< IndexMap1Value, size_type1 >::value));
static_assert(std::is_convertible< IndexMap1Value, size_type1 >::value, "The index map value of the first graph must be convertible to the vertex size type of the first graph.");

BOOST_CONCEPT_ASSERT(
(ReadablePropertyMapConcept< IndexMap2, vertex2_type >));
typedef typename property_traits< IndexMap2 >::value_type IndexMap2Value;
BOOST_STATIC_ASSERT((is_convertible< IndexMap2Value, size_type2 >::value));
static_assert(std::is_convertible< IndexMap2Value, size_type2 >::value, "The index map value of the second graph must be convertible to the vertex size type of the second graph.");


// Edge & vertex requirements
typedef typename graph_traits< Graph1 >::edge_descriptor edge1_type;
Expand All @@ -1185,9 +1185,10 @@ bool vf2_graph_iso(const Graph1& graph1, const Graph2& graph2,
// Vertex order requirements
BOOST_CONCEPT_ASSERT((ContainerConcept< VertexOrder1 >));
typedef typename VertexOrder1::value_type order_value_type;
BOOST_STATIC_ASSERT((is_same< vertex1_type, order_value_type >::value));
BOOST_ASSERT(num_vertices(graph1) == vertex_order1.size());

static_assert(std::is_same< vertex1_type, order_value_type >::value, "The value type of the vertex order and the vertex type of the first graph must be the same type.");
BOOST_ASSERT(num_vertices(graph1) == vertex_order1.size());

if (num_vertices(graph1) != num_vertices(graph2))
return false;

Expand Down
Loading