Repository navigation
test: rename fixture identifiers built on a private product's abbreviation - #483
Merged
Merged
Conversation
…ation Replace the abbreviation in the window-message and near-duplicate test fixtures and in one doc comment with neutral names. The renamed copy sorts after dsUrlOf, so no expected value changes.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test fixtures in two files still used identifiers built on a private product's abbreviation. PR #482 generalized the docs but left these. This renames them to neutral names; no behavior changes.
Changes
__tests__/window-message-synthesizer.test.ts: the event constants, the publisher, listener and receiver function names and the expected event name now useDEMO_AJAX_EVENT,DEMO_OTHER_EVENT,publishDemoLivewire,listenForDemoLivewireAjaxandreceiveDemoSnapshot.__tests__/near-duplicates.test.ts: the third copy of the fixture function is nowwebUrlOfinsrc/web.ts, with the label stringweb.src/graph/near-duplicates.ts: the doc comment's example name iswebUrlOf.Choices
webUrlOfrather thandemoUrlOf: the test compares a name-sorted list that includesdsUrlOf, anddemoUrlOfsorts beforedsUrlOf, which would have forced a reordered expected value.webhas the same length as the old name and sorts afterds, so no expected value changes.>= 0.8,< 0.3) and still hold.Verification
git grepfor the abbreviation listed 18 text lines in these three files. It also matched binary PNGs and two lockfile integrity hashes, which are byte coincidences, not occurrences.vitest run __tests__/near-duplicates.test.ts __tests__/window-message-synthesizer.test.ts: 2 files, 10 tests passed, exit 0.npm run check:agent-docs: exit 0.README rows checked: none apply; no user-visible feature, command, tool, language or number changed.
Summary by cubic
Renames test fixture identifiers built on a private product's abbreviation to neutral names so the tests no longer reference a non-public product. No behavior changes.
webUrlOfreplaces the near-duplicate fixture's name insrc/web.tsinstead ofdemoUrlOf, keeping the expected name-sorted results unchanged.Written for commit ff4757e. Summary will update on new commits.
Summary by CodeRabbit