Repository navigation
fix(build): invalidate kernel stamps for untracked source edits - #394
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (3)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe kernel source stamp now includes untracked files under ChangesKernel source stamps
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The source-stamp change is ready to merge after normal checks. Permission tests may need adjustment if run with elevated filesystem capabilities. Architecture SummaryArchitecture risk: 🟡 Medium · up to The change affects 3 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
Reliability and maintainability
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai full review |
✅ Action performedFull review finished. |
Editing a new, untracked Rust module could leave the native kernel source stamp unchanged. Tests could then use a prebuild made from earlier source bytes. The stamp now includes each untracked path and its content, even inside new directories or when Git status hides untracked files.
Git ignore rules still exclude build outputs. Symlinks contribute their link text, as tracked Git symlinks do; external target changes remain outside that contract. Listing and read failures now stop stamp validation rather than silently accepting an incomplete stamp. The no-Git behavior and explicit native-path override are preserved.
Validation: eight regression cases failed against the original implementation. The unreadable-directory case then caught a successful Git exit with incomplete output. All 14 focused tests now pass.
npm run build, native clippy/release and the final full suite passed on Node 24.21.0 (578 files, 7,388 passes, 39 existing skips). The test floor guard and diff check passed. The focused matrix passed on Linux and macOS (14 tests each) and Windows (5 tests; 9 POSIX cases skipped), without a native build. No extraction or resolution behavior changed.README check: reviewed About this fork's source-install instructions, feature table, parsing/runtime rows and measured results. This internal build freshness fix changes none of their commands, features or reported measurements.