Repository navigation
chore(ci): dotnet-ef moves with EF Core - #351
Merged
Merged
Conversation
Dependabot bumped EF Core to 10.0.14 in #332 but left dotnet-ef at 10.0.13, and the version notice the mismatch prints broke derive-db-docs. Dependabot only reads .config/dotnet-tools.json, found from /src up to the root, so the manifest moves there and dotnet-ef now travels in the nuget group. dotnet-stryker is ignored, since its upgrade has its own procedure. scripts/tool-versions.sh fails when the two differ, first in the Checks job and at pre-commit, naming both versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#332 bumped EF Core to 10.0.14 but left
dotnet-efat 10.0.13. With mismatched versions,dotnet efprints a version notice to stdout, the notice lands indocs/schema.sql, andderive-db-docsfails.Dependabot reads a tool manifest only at
./.config/dotnet-tools.json, searching from the configured directory (/src) up to the repository root (MSBuildHelper.TryGetDotNetToolsJsonPathin dependabot-core). It never read ours, which sat at the root.Evidence
derive-db-docstest failures (dotnet ef emitted something that is not SQL as its first line).After: with the manifest set to 10.0.14 against EF Core 10.0.13, the guard fails in milliseconds with one line:
scripts/tool-versions.test.shpasses 6 cases: equal versions, either side ahead, a similarly named package (.Design) not compared,dotnet-efmissing, manifest missing.dotnet tool restoreanddotnet tool run dotnet-efstill resolve from.config/.@dependabot recreateon Bump the nuget group with 16 updates #332. Its diff should include.config/dotnet-tools.jsonat 10.0.14 and turn green. If the manifest is missing from that diff, thenugetentry also needs to cover/.Merge Danger
Door: two-way
Moving the file back and dropping the step and task undoes it.
Blast Radius: tooling
Local checkouts need nothing new, since
dotnet tool restoresearches.config/. The pre-commit hook gains a step that needsjq, which the other scripts already use.🤖 Generated with Claude Code