Repository navigation
Analysis fixes - #1009
Merged
Merged
Analysis fixes#1009
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review identified no blocking issues, and regression tests cover the corrected behaviors; tests were not executed.
No open issues 🎉
What changed in this PR
Fixes analysis output handling and improves compatibility between result writers and segment extraction.
Changes:
- Handles empty detections, split-output paths, and zero-valued coordinates.
- Standardizes Kaleidoscope output while preserving legacy parsing and quoted CSV fields.
- Improves CLI warnings and adds regression tests.
| File | Description |
|---|---|
| tests/segments/test_segments.py | Tests legacy Kaleidoscope compatibility. |
| tests/analyze/test_writers.py | Tests empty outputs and writer/parser compatibility. |
| tests/analyze/test_analyze.py | Tests output paths, saved coordinates, and warnings. |
| birdnet_analyzer/segments/utils.py | Parses current and legacy Kaleidoscope formats and quoted CSV fields. |
| birdnet_analyzer/config.py | Defines shared Kaleidoscope columns. |
| birdnet_analyzer/analyze/core.py | Fixes output paths, empty results, species labels, and coordinate persistence. |
| birdnet_analyzer/analyze/cli.py | Logs a corrected additional-columns warning. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INDIR, FOLDER, IN FILE, OFFSET, DURATION, TOP1MATCH, TOP1DIST. The names live inconfig.KALEIDOSCOPE_COLUMNS.segmentsreads these files and 2.x ones.Format change: the scientific name and the 2.x extra columns are gone.
segmentsreads quoted fields containing commas, e.g. the 3.0 label "Whales, Dolphins and Porpoises".--split_tableswrites inside the output folder for relative and linked inputs._(Perch) keep their name.--additional_columnswarning is shown again, with corrected text.